Feeling Lucky
?
[#34352] - [4.0] Tags Service Router clean up
- Fixed in Code Base
- 2 Jun 2021
- Medium
- Build: 4.0-dev
- # 34352
- Diff
- joomdonation:com_tags_service_router
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Small clean up to com_tags Router to make IDE happy:
- Added $db property to the class
- Change __construct method to solve warning Optional parameter before required parameter
- Remove un-used variable
Testing Instructions
- Use Joomla 4 nightly build
- Install Blog Sample Data
- Access to Blog menu item, make sure tags are still being displayed in article
- Click on a tag and make sure that the link you are being redirected to still work
Or code review should be enough, too
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-02 10:16:52 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 2 Jun 2021
Thanks!
I have tested this item✅ successfully on 2cfa959
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34352.