? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
31 May 2021

Code review

The deprecated hint is to "Use Joomla\Input\Cli instead"

"Joomla\Input\Cli" doesnt exist at all

"Joomla\CMS\Input\Cli" exists, but that itself is deprecated and says to use Joomla\Input\Cli so in a catch 22

This PR updates "Joomla\CMS\Input\Cli" with a new deprecated message telling people to "Use the joomla/console package instead" which is the same message elsewhere in deprecated statements to do with CLI in Joomla 4

avatar PhilETaylor PhilETaylor - open - 31 May 2021
avatar PhilETaylor PhilETaylor - change - 31 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2021
Category Libraries
avatar richard67 richard67 - test_item - 31 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 31 May 2021

I have tested this item successfully on 52cd462

I can confirm that the deprecated message "Use the joomla/console package instead" is used already elsewhere.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34306.

avatar Quy Quy - test_item - 31 May 2021 - Tested successfully
avatar Quy
Quy - comment - 31 May 2021

I have tested this item successfully on 52cd462


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34306.

avatar Quy Quy - change - 31 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 31 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34306.

avatar wilsonge wilsonge - change - 31 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-31 19:53:18
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 31 May 2021
avatar wilsonge wilsonge - merge - 31 May 2021
avatar wilsonge
wilsonge - comment - 31 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment