Feeling Lucky
?
[#34188] - [4] build.php PHP Warning: Undefined variable $tagVersion
- Closed
- 1 Jun 2021
- Medium
- Build: staging
- # 34188
Steps to reproduce the issue
php build.php --remote=4.0-dev
wait.....
Expected result
No PHP Errors, Notices or warnings...
Actual result
Generating github_release.txt file
PHP Warning: Undefined variable $tagVersion in /Users/phil/Sites/JOOMLA/joomla4/build/build.php on line 632
Warning: Undefined variable $tagVersion in /Users/phil/Sites/JOOMLA/joomla4/build/build.php on line 632
Build of version 4.0.0-beta8-dev complete!System information (as much as possible)
MacOS file system
Additional comments
The cause is because we specified a --remote=4.0-dev in the command and the code only sets $tagVersion if no remote is provided.
// If not given a remote, assume we are looking for the latest local tag
if (!$remote)
{
chdir($repo);
$tagVersion = system($systemGit . ' describe --tags `' . $systemGit . ' rev-list --tags --max-count=1`', $tagVersion);
$remote = 'tags/' . $tagVersion;
chdir($here);
}
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-01 17:29:35 |
| Closed_By | ⇒ | zero-24 |
Will be fixed here and than moved up to 4 after its merged: #34341