[#34173] - [4] Cleanup response from deleting /installation folder
- Fixed in Code Base
- 28 May 2021
- Medium
- Build: 4.0-dev
- # 34173
- Diff
- PhilETaylor:cleaninstaller
User tests: Successful: Unsuccessful:
Summary of Changes
Clean up a TODO left in the installation process on the task of deleting the /installation folder.
Note that there is no point enqueuing a message, because when you destroy a session, you destroy that messageQueue !
Testing Instructions
Install Joomla 4 taking notice of the ajax response when deleting the installation folder on the last step
Actual result BEFORE applying this Pull Request
A full HTML page is returned from the delete installation folder ajax
Expected result AFTER applying this Pull Request
A simple JSON page is returned from the delete installation folder ajax
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
| Category | Installation | ⇒ | Installation JavaScript |
Looks great - trying to figure out if we should be checking the error property or if this is one of these things that's good enough for now given the rarity that this will fail in the first place.
Looks great - trying to figure out if we should be checking the error property or if this is one of these things that's good enough for now given the rarity that this will fail in the first place.
Added this now.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-28 12:48:44 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Now if the folder fails to delete you get a nice JS message, and you can retry as many times as you like by pressing the red button.
And if it succeeds then you get the normal hiding of the red button and dev mode message