Feeling Lucky
?
[#34171] - [4] Remove unused file
- Fixed in Code Base
- 24 May 2021
- Medium
- Build: 4.0-dev
- # 34171
- Diff
- PhilETaylor:patch-200
User tests: Successful: Unsuccessful:
Summary of Changes
Deleted the file as per the instructions contained in the file:
// @TODO Remove when webcomponents get merged into the core
Testing Instructions
Im guessing.. paging @dgrammatiko our resident Webcomponents expert...
Install Joomla. Create some validation errors on installing Joomla on purpose.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
PhilETaylor
- comment
- 24 May 2021
@brianteeman Further reason to delete this file then right?
dgrammatiko
- comment
- 24 May 2021
Probably the todo is wrong but this PR is looking fine
PhilETaylor
- comment
- 24 May 2021
Did you miss the fact this is in the installation folder? Does that make a difference?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 15:38:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 24 May 2021
Merging on review. Indeed as installation nothing will go into script.php :)
richard67
- comment
- 24 May 2021
Ahh good .. installation :-) sometimes we are lucky
it is referencing a layout that doesnt exist
return LayoutHelper::render('installation.template.html.system.message', $displayData);