[#34170] - [4] PASSWORD_ARGON2ID requires PHP 7.3
- Closed
- 24 May 2021
- Medium
- Build: staging
- # 34170
Code review.
Support for Argon2id passwords using PASSWORD_ARGON2ID was added in PHP 7.3.0 and Joomla 4 needs to ensure full compatibility as low as /checks notes/ PHP 7.2.5
Documentation: https://www.php.net/manual/en/function.password-hash.php
using the constant PASSWORD_ARGON2ID therefore cannot be done.
joomla-cms-bot
- | Labels |
Added:
?
|
||
I'm a bit irritated.
Oh. Im sorry. I'm really really sorry that I made a typo and my irritated eyes did not notice the difference between PASSWORD_ARGON2I and PASSWORD_ARGON2ID
Let me go and search for the term for you...
Here is the correct file link reference:
and here is what phpStorm states about it:
This class is referenced by the password.handler.argon2id service in the container provided by:
Im guessing its a won't fix - as this code probably never runs, as the Argon2idHandler::isSupported checks the version number and returns false anyway... It would only get ran if someone used the password.handler.argon2id service directly.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 12:20:38 |
| Closed_By | ⇒ | PhilETaylor |
I'm a bit irritated. You reference to joomla-cms/libraries/src/Authentication/Password/Argon2iHandler.php
PASSWORD_ARGON2IDis not used there. It usesPASSWORD_ARGON2Iwhich is supported since 7.2.0