[#34131] - [3] Fix Delete Batch For User Groups
- Fixed in Code Base
- 29 Jun 2021
- Medium
- Build: staging
- # 34131
- Diff
- YatharthVyas:fix-delete-batch-staging
User tests: Successful: Unsuccessful:
Pull Request for Issue #19346
Thanks @Quy #34094 (comment)
Summary of Changes
Redo of PR #34094 for J3
Testing Instructions
- Visit Backend -> Users -> User Groups
- Add 4 new groups where 2 groups are the parent and 2 are their child:
- A
: - A1
- B
: - B1
- Select all of these items as shown in the gif below. Order is Important: Parent (A) -> It's Child (A1) -> Parent (B) -> It's Child (B1)
- Proceed to Delete them
Before the PR: only the first Parent-Child pair would be deleted and the 2nd Parent-Child was skipped. This happened because the A1 was deleted with A (it's parent) and the loop returned false when it iterated over A1 as it was no longer present in the table.
After the PR: all selected groups will be deleted.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_users |
Wouldn't it be better to have a pull request for each issue so user groups can get a test stand alone?
Sure, Thank you for the suggestion. I will open a separate PR for Content Maps.
| Labels |
Added:
?
|
||
| Category | Administration com_finder com_users | ⇒ | Administration com_users |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34131.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34131.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34131.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34131.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-06-29 20:13:57 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks!
Thank you
Wouldn't it be better to have a pull request for each issue so user groups can get a test stand alone?