Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#34130] - [4] Remove method from exception messages

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
23 May 2021

Summary of Changes

Continuing the slow progress of removing PHP Internal Class and Method names from user visible error messages.

Including class/method names and namespaces is "probably" ok for framework packages aimed at developers - but class/method names should never be shown to end users in error messages. (E.g When was the last time an Amazon shopping error page told you which class and method the error was in? it never does!)

Testing Instructions

mainly code review.

https://example.com/administrator/index.php?option=com_media&format=json&task=api.files&path=local-images:/sampledata/../banner_cradle.jpg&url=asddfsdfg

Actual result BEFORE applying this Pull Request

Screenshot 2021-05-23 at 14 43 31

Expected result AFTER applying this Pull Request

Screenshot 2021-05-23 at 14 48 02

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 23 May 2021
avatar PhilETaylor PhilETaylor - change - 23 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2021
Category ⇒ Libraries
avatar Quy Quy - test_item - 31 May 2021 - Tested successfully
avatar Quy
Quy - comment - 31 May 2021

I have tested this item ✅ successfully on 98fded7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34130.

avatar richard67 richard67 - test_item - 15 Jun 2021 - Tested successfully
avatar richard67
richard67 - comment - 15 Jun 2021

I have tested this item ✅ successfully on 98fded7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34130.

avatar richard67 richard67 - change - 15 Jun 2021
The description was changed
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar richard67 richard67 - edited - 15 Jun 2021
avatar richard67
richard67 - comment - 15 Jun 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34130.

avatar richard67 richard67 - change - 30 Jun 2021
Status Ready to Commit ⇒ Pending
avatar richard67
richard67 - comment - 30 Jun 2021

Back to pending due to updates requested.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34130.

avatar PhilETaylor PhilETaylor - change - 15 Aug 2021
Labels Added: ? ?
Removed: ?
avatar PhilETaylor
PhilETaylor - comment - 15 Aug 2021

Sorry for the delay. Life.

Code 20 is now removed.

avatar PhilETaylor PhilETaylor - change - 6 Mar 2022
Labels Added: Conflicting Files ? ?
Removed: ? ?
avatar PhilETaylor
PhilETaylor - comment - 6 Mar 2022

Conflicts resolved.

avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-03-07 18:33:41
Closed_By ⇒ PhilETaylor
Labels Removed: Conflicting Files ?
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment