User tests: Successful: Unsuccessful:
Pull Request for Issue #34102 .
validating pattern fails when field is not required and empty, this is not correct. This PR fixes this (in line with J3 validation)
pinging @dgrammatiko
see #34102
saving form with empty field is not possible
saving form with empty field works correct
no
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
I think I've started a trend :) :) :)
For JS, we all know that we should ping @dgrammatiko or @Fedik. It's not secret. So no, you are not the one started that trend :D .
However I do worry that the project only has 2 great JS developers though... its quite a bus factor.
I hope @dgrammatiko allows ICMP Echo requests, otherwise we have to cc him :))))
@Ruud68 looks fine.
FWIW HTML5 pattern validation was introduced in 2016 with #13094 and with the reasonable expectation that Joomla 4 will use it in every form. Obviously, this didn't happen and it's not down to the JS devs bus factor but rather to the fact that many devs introduce modern patterns (pun intended) but nobody is willing to follow them (in this case editing the XML files and adding the appropriate pattern="someRegEx"
were the missing steps, and you can't blame the JS devs for not taking the huge load of work to make that happen).
you can't blame the JS devs
Absolutely no blame from me. I was merely commenting that a high(ish) profile project such as Joomla struggles to hire (for free) and retain expert JS (and PHP for that matter) developers. Once you and he leave to work on other things all this JS needs someone who can understand it :)
I have tested this item
Thanks for testing @joomdonation
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 08:00:20 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
I think I've started a trend :) :) :)