? ? Pending

User tests: Successful: Unsuccessful:

avatar Ruud68
Ruud68
23 May 2021

Pull Request for Issue #34102 .

Summary of Changes

validating pattern fails when field is not required and empty, this is not correct. This PR fixes this (in line with J3 validation)
pinging @dgrammatiko

Testing Instructions

see #34102

Actual result BEFORE applying this Pull Request

saving form with empty field is not possible

Expected result AFTER applying this Pull Request

saving form with empty field works correct

Documentation Changes Required

no

avatar Ruud68 Ruud68 - open - 23 May 2021
avatar Ruud68 Ruud68 - change - 23 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2021
Category JavaScript Repository NPM Change
avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

pinging @dgrammatiko

I think I've started a trend :) :) :)

avatar joomdonation
joomdonation - comment - 23 May 2021

I think I've started a trend :) :) :)

For JS, we all know that we should ping @dgrammatiko or @Fedik. It's not secret. So no, you are not the one started that trend :D .

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

However I do worry that the project only has 2 great JS developers though... its quite a bus factor.

avatar Ruud68
Ruud68 - comment - 23 May 2021

I hope @dgrammatiko allows ICMP Echo requests, otherwise we have to cc him :))))

avatar dgrammatiko
dgrammatiko - comment - 23 May 2021

@Ruud68 looks fine.

FWIW HTML5 pattern validation was introduced in 2016 with #13094 and with the reasonable expectation that Joomla 4 will use it in every form. Obviously, this didn't happen and it's not down to the JS devs bus factor but rather to the fact that many devs introduce modern patterns (pun intended) but nobody is willing to follow them (in this case editing the XML files and adding the appropriate pattern="someRegEx" were the missing steps, and you can't blame the JS devs for not taking the huge load of work to make that happen).

avatar PhilETaylor
PhilETaylor - comment - 23 May 2021

you can't blame the JS devs

Absolutely no blame from me. I was merely commenting that a high(ish) profile project such as Joomla struggles to hire (for free) and retain expert JS (and PHP for that matter) developers. Once you and he leave to work on other things all this JS needs someone who can understand it :)

avatar joomdonation joomdonation - test_item - 25 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 25 May 2021

I have tested this item successfully on 7c0fd21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124.

avatar Ruud68
Ruud68 - comment - 25 May 2021

Thanks for testing @joomdonation

avatar Quy Quy - test_item - 27 May 2021 - Tested successfully
avatar Quy
Quy - comment - 27 May 2021

I have tested this item successfully on 7c0fd21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124.

avatar Quy Quy - change - 27 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 27 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124.

avatar Ruud68
Ruud68 - comment - 28 May 2021

Thanks for testing and RTC @Quy

avatar rdeutz rdeutz - close - 29 May 2021
avatar rdeutz rdeutz - merge - 29 May 2021
avatar rdeutz rdeutz - change - 29 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-29 08:00:20
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment