[#34068] - [4.0] site config items
- Fixed in Code Base
- 22 May 2021
- Medium
- Build: 4.0-dev
- # 34068
- Diff
- brianteeman:friday1
User tests: Successful: Unsuccessful:
Pull Request for #29315
Steps to reproduce the issue
install sample data
login to frontend as super admin
Click Site Settings
Set "Site Name in Page Titles" to After
Save
Expected result
On every page, on the frontend, the site name should be appended to the page title.
Actual result
The site name is missing from the following pages
Click Site Settings menu item
Click Template Settings menu item
Click to edit a module
In addition Site Settings and Template Settings ignore all the other menu settings such as show heading and pageclass
Edit a module doesnt have a menu item so that doesnt apply for this one
This PR should resolve all of this.
@PhilETaylor could you please check the docblocks - I didn't really know what I was supposed to be doing there.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34068.
@brianteeman Could you check the review comments? Thanks in advance.
| Labels |
Added:
?
?
|
||
| Labels |
Removed:
?
|
||
Sorry @brianteeman . I forgot the Templates view in my PR. Just made another PR brianteeman#126 . Could you please merge that PR, too ? Then we will get someone here to test it. Thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34068.
@Abernyte-Git @PhilETaylor Could you test again? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34068.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34068.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-22 10:32:29 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
thank you
I have tested this item✅ successfully on 030b0a5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34068.