NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 May 2021

Changes to inline block so that the message if displayed does not cause the field to move. (which is an accessibility error and ugly)

Pull Request for Issue #32692 .

before

before

after

after

avatar brianteeman brianteeman - open - 20 May 2021
avatar brianteeman brianteeman - change - 20 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2021
Category Front End Templates (site) NPM Change
avatar sandramay0905 sandramay0905 - test_item - 21 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 21 May 2021

I have tested this item successfully on c91ce54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar C-Lodder
C-Lodder - comment - 21 May 2021

Downvoting this.

  1. It's common practice to have error messages displayed below the field
  2. You're assuming that the error message will always fit on a single line which is not true. Device size and language content length may vary
avatar Abernyte-Git Abernyte-Git - test_item - 21 May 2021 - Tested unsuccessfully
avatar Abernyte-Git
Abernyte-Git - comment - 21 May 2021

I have tested this item ? unsuccessfully on c91ce54

Sorry, this must be user error here but but I can't replicate this change. I have tried multiple browsers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar PhilETaylor PhilETaylor - test_item - 21 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 21 May 2021

I have tested this item successfully on c91ce54

the PR does what it says it does, I dont like it but its not my opinion that counts, the code, as provided in the PR, works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar richard67
richard67 - comment - 21 May 2021

@Abernyte-Git Have you recompiled the scss using npm after having applied the changes in this PR?

avatar Abernyte-Git Abernyte-Git - test_item - 21 May 2021 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 21 May 2021

I have tested this item successfully on c91ce54

Duh...stands in corner with dunces hat on. Thank you Richard.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar richard67 richard67 - change - 21 May 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 21 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar richard67 richard67 - change - 21 May 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 21 May 2021

Sorry, saw @C-Lodder 's comment too late. Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar Fedik
Fedik - comment - 21 May 2021

I am agree with @C-Lodder

avatar richard67
richard67 - comment - 21 May 2021

The issue was that the "jumping" of the fields was annoying for some users. But thinking more about it now, I think this "jumping" makes it easier to see that there is something wrong, while just the red colour of the field label plus the inline validation message might not get so much attention without this "jumping", especially not from colour blind users.

avatar chmst
chmst - comment - 21 May 2021

My2Cent: In one line the whole looks like a bad sentence which "makes me think".

avatar brianteeman
brianteeman - comment - 21 May 2021

It was an attempt and you are free to reject it. The current behaviour of moving the fields is an accessibility failure. You cant just display the message after the field either - it will need id and aria so that the message would be announced before the field

avatar C-Lodder
C-Lodder - comment - 21 May 2021

Do you have a link to the WCAG standard that mentions moving content fails?
Imterested in reading it for work and personal stuff too

avatar chmst
chmst - comment - 21 May 2021

If it is an issue. Maybe we can replace the label by a complete sentence in case off an error?

avatar C-Lodder
C-Lodder - comment - 21 May 2021

I can't find anything in the article that refers to form field error or similar scenarios.
Correct me if I'm wrong, but the moving content they refer to sounds like constant moving, e.g Twitch Chat, which may be too hard to scan each message before the next one appears. Other examples would be flashing banners.
The form field error in this case is a single jump, that does not occur at intervals, but will be reverted upon user action.

avatar richard67
richard67 - comment - 23 May 2021

I think we need a decision here => pinging @wilsonge .

avatar richard67 richard67 - change - 23 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 May 2021

RTC because it has 3 successful tests, but also setting the RLDQ (release lead decision queue) label to make clear it needs a decision before getting merged.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34066.

avatar richard67
richard67 - comment - 26 May 2021

@brianteeman Maybe to come forward you could improve this PR a bit? It would need at least a space between the "required" asterisk at the end of the field label and the validation message so solve @chmst 's comment above #34066 (comment) ... or even better would be if we could make it float to the right so it right-aligns with the input field?

avatar rdeutz
rdeutz - comment - 29 May 2021

After some discussions closing this here, it's not really so much better.

avatar rdeutz rdeutz - close - 29 May 2021
avatar rdeutz rdeutz - change - 29 May 2021
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2021-05-29 08:25:42
Closed_By rdeutz
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment