[#34044] - [4.0] Remove hr in frontend edit module
- Closed
- 30 May 2021
- Medium
- Build: 4.0-dev
- # 34044
- Diff
- rjharishabh:frontend-hr
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Remove <hr> in the frontend edit module
Testing Instructions
Try to edit module in frontend
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config |
The line is there intentionally as a separator between different parts of the form
Is it necessary to separate this way?
I don't think so
@rjharishabh I agree that the hr looks more like a bug than a feature ;)
Have you an idea for grouping the input fields?
it will of course depend on the template as well
Sorry for the late reply
Is it really necessary to group
there is no grouping required between position and status (should be similar to backend)
And the note is a text field and options is an accordion (IMO it's already separated)
I don't know much about design
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34044.
the hr looks odd but removing it is not the right way because we loosing the separation in the backend
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-30 09:10:20 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@rjharishabht this whole layout needs some work. Thank you for opening this PR anyway, this was really useful, as obviously the layout was not properly analysed before.
@rjharishabht this whole layout needs some work. Thank you for opening this PR anyway, this was really useful, as obviously the layout was not properly analysed before.
Got it
Thanks
The line is there intentionally as a separator between different parts of the form