[#34043] - [4] Use RuntimeStorage on CLI
- Fixed in Code Base
- 22 May 2021
- Medium
- Build: 4.0-dev
- # 34043
- Diff
- PhilETaylor:RuntimeStorage
User tests: Successful: Unsuccessful:
After considerable debugging... like hours with xdebug and stepping through the code...
Rather than revert #33145 with PR #33993 for issue #32966 this PR will fix the already merged code so that RuntimeStorage is used (basically reverting PART of the PR), and along with the previous PR #33145 change to add the session.handler into the container, this fixes the issue reported in #32966 when deleting users.
The session.handler is needed because after deleting users using the CLI, plugins are triggered by the dispatcher, the onUserAfterDelete event is triggered in the plgUserJoomla class
In this class it attempts to "Fetch all session IDs for the user account so they can be destroyed". To do this it attempts to call the session.manager from the container, which doesnt exist ( issue #32966 )
#33145 has added a session.manager into the container, which the plugin needs to be there.
This PR simply changes the JoomlaStorage for the RuntimeStorage
Testing Instructions
php cli/joomla.php user:add
test
test
test@example.xom
6
php cli/joomla.php user:delete
test
yes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Up to @wilsonge
@PhilETaylor Maybe for the issue, but PR #33993 is up to you, or not?
I honestly dont know which of the two approaches satisfy @wilsonge (and Im waiting to see which are thumbed down by @SharkyKZ )
At the end of the day, the container needs session.handler else the plugin cannot run. The only other approach is the nasty catching of the exception and silently allowing it to fail, but I dont think that is graceful either.
@PhilETaylor If both PR's would solve the issue and we just have to chose one, we should close the issue, but if there is something remaining unsolved from that issue we should leave it open. I just need to know if I can close the issue or not,
Thanks.
If this works this would be my preferred candidate!
It works.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34043.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34043.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34043.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-22 21:55:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
@PhilETaylor So issue #32966 and PR #33993 can be closed?