The decision for the menu collapsible behaviour shouldn't be in the template but in the module menu.
This solution is the best showcase of why Joomla ended up having a gazillion toggle switches and being completely disaster on the UX...
Just use a new layout in the mod_menu...

Beside this, it should be made consistently also in the error.php file of Cassiopeia.

Beside this, it should be made consistently also in the error.php file of Cassiopeia.

If this get approved, of course

Just use a new layout in the mod_menu...

I understand you, but creating a new layout for the bootstrap part combined with the existent core menu and the new metismenu from Cassiopeia is a level over my skills... I would love to know how to do that.

I would love to know how to do that

Maybe something like this: https://github.com/joomla/joomla-cms/compare/4.0-dev...dgrammatiko:—respect-the-architecture-4.0-dev?expand=1

Expands the layouts instead of adding more switches to the template (template doesn't and should never have the responsibility to modify the menu, there's a module for that [modular architecture]).

Ahhh.. I was thinking too complicated ;-) Your code is much simpler than I thought

Will you create the PR?

Will you create the PR?

Since you already have this one open you could adjust the code here. There's one thing missing: remove the burger text from the template and add it to the mod_menu

Is this burger removal a vegan thing? :-)

Is this burger removal a vegan thing? :-)

I guess the burger removal from any human is totally biodegradatable :D

Thank you @dgrammatiko ! I will rework the PR tomorrow.

I have tested this item ✅ successfully on d878714

@rbuelund would you test this PR?

I would like to test it, but how - I have no test setup.. I have a beta-8 site.

@drmenzelit Do I understand right that the new collapse-layouts are equal to the default layouts without this PR? If so, then blog sample data should be changed for the "Main Menu Blog" using the new collapsible layout here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/sampledata/blog/blog.php#L1437

@drmenzelit Do I understand right that the new collapse-layouts are equal to the default layouts without this PR? If so, then blog sample data should be changed for the "Main Menu Blog" using the new collapsible layout here:

https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/sampledata/blog/blog.php#L1437

But I'm not sure. @chmst What do you think? Let blog sample data like it is now so it will use the non-collapsible layout after this PR is applied? Or change it so it uses the collapsible layout and so behaves like before?

@richard67 , @chmst I think, we should change the sample data to use the collapsible layout

I would like to test it, but how - I have no test setup.. I have a beta-8 site.

You can download a prebuilt package from this PR and install it

Sorry - I dot not really now what to download and from where... and I am not running on local server

@rbuelund go to https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33978/downloads/44050/ and download the file from the second link Joomla_4.0.0-beta8-dev+pr.33978-Development-Full_Package.zip. Then install it as a new site and do your test

Hmmm.. not quite ?? If I install CK Maximenu module - then I have no posibility to select the template layout ?? The burger is still there..

Hmmm.. not quite ?? If I install CK Maximenu module - then I have no posibility to select the template layout

For sure you can't use the layouts of X module on Y module. This is expected

Hmmm.. not quite ?? If I install CK Maximenu module - then I have no posibility to select the template layout ??

@rbuelund It's a module layout, not a template layout, what this PR provides. So if your 3rd party module doesn't allow to select if it can be collapsed, the it's not a problem with the CMS.

Well - this was what I originally wrote as my problem: "If one uses the Cassiopeia template and wants to use another horisontal menu extension as menu instead of Cassiopeias own menu, then Cassiopeias mobile menu icon is still shown." - I wrote explicitly "another extension" - in the thread here: #33918

Well - this was what I originally wrote as my problem: "If one uses the Cassiopeia template and wants to use another horisontal menu extension as menu instead of Cassiopeias own menu, then Cassiopeias mobile menu icon is still shown." - I wrote explicitly "another extension" - in the thread here: #33918

@rbuelund If that other menu extension will not provide a menu toggle, no such toggle will be shown, so I don't really understand your problem now.

The toggle is indeed still shown with this solution

Ahh sorry - my wrong. No, it works.

@rbuelund Finally ? Thanks. If that was a successful test, could you mark your test result in the issue tracker? Just go to here https://issues.joomla.org/tracker/joomla-cms/33978 , use the "Test this" button, select the right test result and submit. Thanks in advance.

I have tested this item ✅ successfully on d878714

This works as it should :-)

@dgrammatiko Finally, after this PR goes the right way now, maybe you should revert your "thumb down" for the description?

Done

RTC

@drmenzelit @chmst This PR will need a follow-up PR for making the Blog Sample Data use the collapsible dropdown layout, see my comment above #33978 (comment) .

Who wants to make it?

@chmst is the expert for sample data :-)

Thank you! The blog sample data change will follow right now.

Does anybody know if there is some documentation to be updated with the changes from this PR?

For Blog sample data update see PR #34086 . Please test.

If there are more than one collapsible menus on a site, all are toggled simultaneoulsy (on cassiopiea).

If there are more than one collapsible menus on a site, all are toggled simultaneoulsy (on cassiopiea).

The code implies that the collapsible layout will be used only once per page because it has an ID that needs to be unique <div class="collapse navbar-collapse" id="navbar">. If you want to allow multiple instances of the module in the page you need to change the id to id="navbar-<?php echo $module->id; ?>" and also all the aria attributes referring to that id. Something like

<nav class="navbar navbar-expand-md">
	<button class="navbar-toggler navbar-toggler-right" type="button" data-bs-toggle="collapse" data-bs-target="#navbar-<?php echo $module->id; ?>" aria-controls="navbar-<?php echo $module->id; ?>" aria-expanded="false" aria-label="<?php echo Text::_('MOD_MENU_TOGGLE'); ?>">
		<span class="icon-menu" aria-hidden="true"></span>
	</button>
	<div class="collapse navbar-collapse" id="navbar-<?php echo $module->id; ?>">
		<?php require __DIR__ . '/default.php'; ?>
	</div>
</nav>

Thank you! In general, sites will have only one collapsible menu. So am not sure yet if it is a nice feature.