[#33977] - [4.0] GD, iconv and intl settings test
- Fixed in Code Base
- 23 May 2021
- Medium
- Build: 4.0-dev
- # 33977
- Diff
- brianteeman:update2
User tests: Successful: Unsuccessful:
In a recent PR the status of these two php functions was added to the system info.
This PR adds the same information to the pre-install and pre-update checks
And additionally adds GD to all three places
In order to test this page you will need to force joomla to see an update. One way to do this is to set the update channel to custom and use this url https://update.joomla.org/core/nightlies/next_major_list.xml
When you have done that then you will see the pre-update page that this PR is addressing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings Installation |
| Labels |
Added:
?
?
|
||
apologies for the delay is was speaking at a conference
Just a thought - maybe we should also add the GD check?
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
Its only a language string change so I guess with a maintainer review to confirm the other tests are still valid
... so I guess with a maintainer review to confirm the other tests are still valid
Am on the way. How about Phil's idea to do that also for the GD library check? You wanna make another PR?
yes - i will do a separate pr - out of time right now
I've restored the previous test results in the issue tracker so they are properly counted again, because the commit which invalidated them was just a text change.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate Language & Strings Installation | ⇒ | Administration com_admin com_joomlaupdate Language & Strings Installation |
| Title |
|
||||||
As it hadnt been merged yet I added GD support to this PR to avoid any merge conflicts etc.
Please retest
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
I have tested this item
Pre-Update Check:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-23 21:15:19 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Thx
@brianteeman Could you fix the code style errors reported here? https://ci.joomla.org/joomla/joomla-cms/43947/1/6 Thanks in advance.