? ? ?

Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 May 2021

In a recent PR the status of these two php functions was added to the system info.

This PR adds the same information to the pre-install and pre-update checks

And additionally adds GD to all three places

In order to test this page you will need to force joomla to see an update. One way to do this is to set the update channel to custom and use this url https://update.joomla.org/core/nightlies/next_major_list.xml

When you have done that then you will see the pre-update page that this PR is addressing.
image

avatar brianteeman brianteeman - open - 19 May 2021
avatar brianteeman brianteeman - change - 19 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2021
Category Administration com_joomlaupdate Language & Strings Installation
avatar richard67
richard67 - comment - 19 May 2021

@brianteeman Could you fix the code style errors reported here? https://ci.joomla.org/joomla/joomla-cms/43947/1/6 Thanks in advance.

avatar brianteeman brianteeman - change - 19 May 2021
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 19 May 2021

apologies for the delay is was speaking at a conference

avatar PhilETaylor
PhilETaylor - comment - 19 May 2021

Just a thought - maybe we should also add the GD check?

avatar brianteeman brianteeman - change - 19 May 2021
Title
[4.0] iconv and intl settingss test
[4.0] iconv and intl settings test
avatar brianteeman brianteeman - edited - 19 May 2021
avatar Quy Quy - test_item - 21 May 2021 - Tested successfully
avatar Quy
Quy - comment - 21 May 2021

I have tested this item successfully on bcb92b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar sandramay0905 sandramay0905 - test_item - 21 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 21 May 2021

I have tested this item successfully on bcb92b5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar brianteeman
brianteeman - comment - 21 May 2021

Its only a language string change so I guess with a maintainer review to confirm the other tests are still valid

avatar richard67
richard67 - comment - 21 May 2021

... so I guess with a maintainer review to confirm the other tests are still valid

Am on the way. How about Phil's idea to do that also for the GD library check? You wanna make another PR?

avatar brianteeman
brianteeman - comment - 21 May 2021

yes - i will do a separate pr - out of time right now

avatar richard67 richard67 - alter_testresult - 21 May 2021 - Quy: Tested successfully
avatar richard67 richard67 - alter_testresult - 21 May 2021 - sandramay0905: Tested successfully
avatar richard67
richard67 - comment - 21 May 2021

I've restored the previous test results in the issue tracker so they are properly counted again, because the commit which invalidated them was just a text change.

avatar richard67 richard67 - change - 21 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar brianteeman brianteeman - change - 22 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Administration com_joomlaupdate Language & Strings Installation Administration com_admin com_joomlaupdate Language & Strings Installation
avatar brianteeman brianteeman - change - 22 May 2021
Title
[4.0] iconv and intl settings test
[4.0] GD, iconv and intl settings test
avatar brianteeman brianteeman - edited - 22 May 2021
avatar brianteeman brianteeman - change - 22 May 2021
The description was changed
avatar brianteeman brianteeman - edited - 22 May 2021
avatar brianteeman
brianteeman - comment - 22 May 2021

As it hadnt been merged yet I added GD support to this PR to avoid any merge conflicts etc.

Please retest

avatar richard67 richard67 - change - 22 May 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 22 May 2021

Back to pending.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar sandramay0905 sandramay0905 - test_item - 23 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 23 May 2021

I have tested this item successfully on 134ec31

Pre-Update Check:

image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.
avatar infograf768 infograf768 - test_item - 23 May 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 23 May 2021

I have tested this item successfully on 134ec31


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar infograf768 infograf768 - change - 23 May 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 23 May 2021

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33977.

avatar richard67 richard67 - change - 23 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-23 21:15:19
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 23 May 2021
avatar richard67 richard67 - merge - 23 May 2021
avatar richard67
richard67 - comment - 23 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 23 May 2021

Thx

Add a Comment

Login with GitHub to post a comment