@PhilETaylor Not sure if you are right here. See https://github.com/joomla-framework/input/blob/2.0-dev/src/Input.php#L166 .

This is set, you linked to get

Oh ... I need sleep. For set you are right.

No idea - but it is clear what was there before was clearly wrong and needs addressing. If this PR is incorrect, it doesnt change the fact that the current code is wrong :)

Tried to look at it again but unsure what to do :(. I don't know why we need to attempt to get data from $this->input and if it does not exist, try to get it from $this->input->get ?

Isn't $this->input contains data from both POST and GET already? Or there is something special here :( ? In ArticlesController for example, we do not need to use $this->input->get at all. See https://github.com/joomla/joomla-cms/blob/4.0-dev/api/components/com_content/src/Controller/ArticlesController.php#L48-L79 .

Honestly right now I can’t remember why this would be either. Pretty sure we just want to be checking GET. Will look again tomorrow with a fresh pair of eyes

@wilsonge Now I understand more about webservice, I think just getting data from GET would be right. However, for shorter code, using just $this->input->get instead of $this->input->get->get could work, too. The code here could be simplified.

However, for shorter code, using just $this->input->get instead of $this->input->get->get could work, too

It can work but would allow query overriding which would be wrong. For the API we generally should be fairly strict about the data sources.

This PR should be updated to use same method with #34288 . We do not want to individual model states like this anymore.

Closing as no possibility of being merged.