Feeling Lucky
?
?
[#33959] - [4] cleanup code
- Fixed in Code Base
- 19 May 2021
- Medium
- Build: 4.0-dev
- # 33959
- Diff
- PhilETaylor:cliparams
User tests: Successful: Unsuccessful:
Some people read a book in bed, I review code, don't @ me :)
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
richard67
- comment
- 19 May 2021
I have tested this item
I can confirm that the textfunction of the SymfonyStyle class has only 1 parameter. I hope that was the right place to check.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33959.
| Labels |
Added:
?
|
||
richard67
- comment
- 19 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33959.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 19 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33959.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-19 20:52:19 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
chmst
- comment
- 19 May 2021
@richard67 I hope so too :).
Thanky you all
PhilETaylor
- comment
- 19 May 2021
Rest assured this PR is right. The text and error methods both have one param.
/**
* {@inheritdoc}
*/
public function text($message)
{
$this->autoPrependText();
$messages = \is_array($message) ? array_values($message) : [$message];
foreach ($messages as $message) {
$this->writeln(sprintf(' %s', $message));
}
}
public function error($message)
{
$this->block($message, 'ERROR', 'fg=white;bg=red', ' ', true);
}
I have tested this item✅ successfully on 6faef61
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33959.