? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
18 May 2021

Code review

avatar PhilETaylor PhilETaylor - open - 18 May 2021
avatar PhilETaylor PhilETaylor - change - 18 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category Administration com_categories Modules Templates (admin) Layout Libraries Unit Tests
avatar joomdonation joomdonation - test_item - 22 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 22 May 2021

I have tested this item successfully on fdd1447


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33948.

avatar joomdonation
joomdonation - comment - 22 May 2021

@PhilETaylor Could you synchronize this branch with latest 4.0-dev? Some changes in this PR was already included in your other merged PRs.

avatar PhilETaylor PhilETaylor - change - 22 May 2021
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2021
Category Administration com_categories Modules Templates (admin) Layout Libraries Unit Tests Administration com_categories Templates (admin) Layout Libraries Unit Tests
avatar PhilETaylor
PhilETaylor - comment - 22 May 2021

Done - went from 10 files to 6

avatar joomdonation joomdonation - alter_testresult - 22 May 2021 - joomdonation: Tested successfully
avatar joomdonation joomdonation - change - 22 May 2021
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 22 May 2021

Reviewed once more time again after synchronizing with 4.0-dev. RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33948.

avatar Quy Quy - test_item - 22 May 2021 - Tested successfully
avatar Quy
Quy - comment - 22 May 2021

I have tested this item successfully on 9eecfe8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33948.

avatar richard67 richard67 - change - 23 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-23 20:14:48
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 23 May 2021
avatar richard67 richard67 - merge - 23 May 2021
avatar richard67
richard67 - comment - 23 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment