Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33947] - [4.0] Solving the wrong method on button margin

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar deveshprasad
deveshprasad
18 May 2021

Pull Request for Issue #33717 .

Summary of Changes

Earlier wrong method bootstrap margin was used individually on both the buttons

Solved it now using the SCSS margin.

@include media-breakpoint-down(md) { .btn { margin-bottom: .25rem; } }

Testing Instructions

In the dashboard go to the Post Installation Messages page.

Actual result BEFORE applying this Pull Request

13 05 2021_15 45 42_REC

Expected result AFTER applying this Pull Request

13 05 2021_20 50 17_REC

Documentation Changes Required

No

avatar deveshprasad deveshprasad - open - 18 May 2021
avatar deveshprasad deveshprasad - change - 18 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category ⇒ Administration com_postinstall Templates (admin) NPM Change
avatar brianteeman
brianteeman - comment - 18 May 2021

administrator/templates/atum/scss/vendor/bootstrap/_buttons.scss

8 | 44:3 ✖ Unexpected missing end-of-source newline no-missing-end-of-source-newline

avatar Quy
Quy - comment - 18 May 2021

Thank you for the PR. Both have been fixed as stated.

avatar Quy Quy - change - 18 May 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-18 20:52:54
Closed_By ⇒ Quy
Labels Added: NPM Resource Changed ?
avatar Quy Quy - close - 18 May 2021

Add a Comment

Login with GitHub to post a comment