NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar eopws
eopws
18 May 2021

Pull Request for Issue #33943.

Summary of Changes

Fix of the narrow column width in media manager.

Testing Instructions

Go to Content > Media
Click List icon.
Go to sampledata > parks > landscape

Actual result BEFORE applying this Pull Request

Icons column has small width

Expected result AFTER applying this Pull Request

Icons column has enough width

avatar eopws eopws - open - 18 May 2021
avatar eopws eopws - change - 18 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category Repository NPM Change
avatar Quy Quy - test_item - 18 May 2021 - Tested successfully
avatar Quy
Quy - comment - 18 May 2021

I have tested this item successfully on cfb3f4e

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar ChristineWk ChristineWk - test_item - 18 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 May 2021

I have tested this item successfully on cfb3f4e

With Prebuild Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar brianteeman
brianteeman - comment - 18 May 2021

Sorry but this is not correct

image

avatar eopws
eopws - comment - 18 May 2021

@brianteeman
Is that because of incorrect line break?
The problem from the issue is caused by lack of width in icon column, and I know two solutions:

  • The one proposed in the PR
  • Set min-width property to icon cell

If you consider line break a bad solution I can replace it with min-width property.

avatar brianteeman
brianteeman - comment - 18 May 2021

The size of the other columns is way too big. you really dont want to wrap a filename unless you absolutely have to

image

Better to set some more sensible column widths such as


.media-browser-table .type {
    width: 5%;
}

.media-browser-table .size {
    width: 10%;
    text-align: right;
}

.media-browser-table .dimension {
    width: 15%
}

.media-browser-table .created,.media-browser-table .modified {
    width: 15%;
}

avatar eopws
eopws - comment - 18 May 2021

@brianteeman

Better to set some more sensible column widths such as

But we are still gonna have the problem when the file name is too big. Try to add symbols to a filename in devtools.
I think it's cool to change column widths as you proposed and add the word-break: break-all; property to 'name' columns. Then if the filename will be very big the layout would not be broken.

avatar brianteeman
brianteeman - comment - 18 May 2021

But we are still gonna have the problem when the file name is too big.

Always going to happen but we can reduce the times when it will happen by setting sensible column widths in the beginning - especially when the width of the data in the column is never going to be that wide

avatar eopws eopws - change - 18 May 2021
Labels Added: NPM Resource Changed ?
avatar eopws
eopws - comment - 18 May 2021

Please, test new patch.

avatar ChristineWk ChristineWk - test_item - 18 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 May 2021

I have tested this item successfully on b1b17be

Installed the new Prebuild Package. It's much better now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar brianteeman brianteeman - test_item - 18 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 May 2021

I have tested this item successfully on b1b17be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar richard67 richard67 - change - 18 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 18 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar Quy
Quy - comment - 18 May 2021

The first column should align.

33945

avatar richard67 richard67 - change - 18 May 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 18 May 2021

Back to pending, see comment #33945 (comment) .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar eopws eopws - change - 19 May 2021
Labels Added: ?
avatar eopws
eopws - comment - 19 May 2021

The patch works on my machine. Please, test it too.

avatar ceford ceford - test_item - 19 May 2021 - Tested successfully
avatar ceford
ceford - comment - 19 May 2021

I have tested this item successfully on 0d9143d

Better that it was. But why does the icon cell have a bottom border but the rest of the row does not?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar eopws
eopws - comment - 19 May 2021

But why does the icon cell have a bottom border but the rest of the row does not?

What do you mean? Please, send screenshot.

avatar ChristineWk
ChristineWk - comment - 19 May 2021

I'm not sure & see it now in this way:

screen shot 2021-05-19 at 09 31 01

or what do you mean @ceford?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar eopws
eopws - comment - 19 May 2021

#33945 (comment)
I can fix it, but it is out of the PR's topic.
Also it was before applying the patch too.

avatar ChristineWk ChristineWk - test_item - 19 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 19 May 2021

I have tested this item successfully on 0d9143d

@eopws OK. Don't remember the previous last line/border :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar richard67 richard67 - change - 19 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 19 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.

avatar Quy
Quy - comment - 19 May 2021

In Firefox, it is a pixel off to the left. In Chrome, it is fine.

The toggle checkbox is 50px.

Please see if you can use the same value and look good in both browsers.

avatar eopws
eopws - comment - 19 May 2021

In Firefox, it is a pixel off to the left. In Chrome, it is fine.

The toggle checkbox is 50px.

Please see if you can use the same value and look good in both browsers.

In Chrome, it is a pixel off to the right, if set min-width equals to 50px.
But in Chrome it doesn't seem to be critical while it looks bad in Firefox.

avatar Quy Quy - change - 19 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-19 20:11:07
Closed_By Quy
Labels Added: ?
Removed: ?
avatar Quy Quy - close - 19 May 2021
avatar Quy Quy - merge - 19 May 2021
avatar Quy
Quy - comment - 19 May 2021

Merging as this is better than before. Thank you!

Add a Comment

Login with GitHub to post a comment