User tests: Successful: Unsuccessful:
Pull Request for Issue #33943.
Fix of the narrow column width in media manager.
Go to Content > Media
Click List icon.
Go to sampledata > parks > landscape
Icons column has small width
Icons column has enough width
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
I have tested this item
With Prebuild Package
@brianteeman
Is that because of incorrect line break?
The problem from the issue is caused by lack of width in icon column, and I know two solutions:
If you consider line break a bad solution I can replace it with min-width property.
The size of the other columns is way too big. you really dont want to wrap a filename unless you absolutely have to
Better to set some more sensible column widths such as
.media-browser-table .type {
width: 5%;
}
.media-browser-table .size {
width: 10%;
text-align: right;
}
.media-browser-table .dimension {
width: 15%
}
.media-browser-table .created,.media-browser-table .modified {
width: 15%;
}
Better to set some more sensible column widths such as
But we are still gonna have the problem when the file name is too big. Try to add symbols to a filename in devtools.
I think it's cool to change column widths as you proposed and add the word-break: break-all;
property to 'name' columns. Then if the filename will be very big the layout would not be broken.
But we are still gonna have the problem when the file name is too big.
Always going to happen but we can reduce the times when it will happen by setting sensible column widths in the beginning - especially when the width of the data in the column is never going to be that wide
Labels |
Added:
NPM Resource Changed
?
|
Please, test new patch.
I have tested this item
Installed the new Prebuild Package. It's much better now.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Pending |
Back to pending, see comment #33945 (comment) .
Labels |
Added:
?
|
The patch works on my machine. Please, test it too.
I have tested this item
Better that it was. But why does the icon cell have a bottom border but the rest of the row does not?
But why does the icon cell have a bottom border but the rest of the row does not?
What do you mean? Please, send screenshot.
I'm not sure & see it now in this way:
or what do you mean @ceford?
#33945 (comment)
I can fix it, but it is out of the PR's topic.
Also it was before applying the patch too.
I have tested this item
@eopws OK. Don't remember the previous last line/border :-)
Status | Pending | ⇒ | Ready to Commit |
RTC
In Firefox, it is a pixel off to the left. In Chrome, it is fine.
The toggle checkbox is 50px.
Please see if you can use the same value and look good in both browsers.
In Firefox, it is a pixel off to the left. In Chrome, it is fine.
The toggle checkbox is 50px.
Please see if you can use the same value and look good in both browsers.
In Chrome, it is a pixel off to the right, if set min-width equals to 50px.
But in Chrome it doesn't seem to be critical while it looks bad in Firefox.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-19 20:11:07 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
Removed: ? |
Merging as this is better than before. Thank you!
I have tested this item✅ successfully on cfb3f4e
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33945.