? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
18 May 2021

Summary of Changes

The search suggestions are not lowercasing the search term when searching for suggestions, thus having no result when the search term starts with an uppercase character. This should fix this.

Testing Instructions

  1. Setup Smart Search
  2. Search for "Joomla" and see no suggestions
  3. Apply patch
  4. Type in "Joo" and see that you get suggestions with "joomla"
avatar Hackwar Hackwar - open - 18 May 2021
avatar Hackwar Hackwar - change - 18 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category Front End com_finder
avatar richard67
richard67 - comment - 18 May 2021

For some reason this PR doesn't work for me on current staging, while the same fix for J4 with PR #33940 worked for me on 4.0-dev. I have no idea why. Will continue to check.

avatar sandramay0905 sandramay0905 - test_item - 19 May 2021 - Tested unsuccessfully
avatar sandramay0905
sandramay0905 - comment - 19 May 2021

I have tested this item 🔴 unsuccessfully on 7baba66

Typed in "Joo", no suggestions.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

avatar Hackwar Hackwar - change - 19 May 2021
Labels Added: ?
avatar Hackwar
Hackwar - comment - 19 May 2021

Please test again. This should work now...

avatar sandramay0905 sandramay0905 - test_item - 19 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 19 May 2021

I have tested this item ✅ successfully on 6c5478d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

avatar richard67 richard67 - test_item - 19 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 19 May 2021

I have tested this item ✅ successfully on 6c5478d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

avatar richard67 richard67 - change - 19 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 19 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33942.

avatar chmst chmst - change - 10 Jun 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-06-10 18:08:14
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 10 Jun 2021
avatar chmst chmst - merge - 10 Jun 2021
avatar chmst
chmst - comment - 10 Jun 2021

Thanks!

Add a Comment

Login with GitHub to post a comment