? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 May 2021

Pull Request for #31836 (comment) .

Summary of Changes

Fix PHP notice caused by an undefined variable $article being used as function parameter where it should be null, see other places in that file using ActionlogsHelper::getContentTypeLink without a media object.

The notice is caused by PR #31836 which has impelemnted that code. It looks like a remainder from copy and paste.

Testing Instructions

  1. Set error reporting to maximum and log PHP errors into a file.

  2. Upload an item into the media manager.

  3. Check in the action log for the action from step 2 that the link on the uploaded file name is correct and leads to the folder of the uploaded item.

  4. Change the options of an extension and check that the action is logged correctly.

  5. Install or uninstall an extension and check that the action is logged correctly.

  6. Check your PHP log if there are logged any PHP notices.

Result. The PHP error log shows PHP notice(s) "Undefined variable: article".

  1. Apply the patch of this PR.

  2. Repeat steps 2 to 6.

Result. No PHP notice(s) "Undefined variable: article".

Actual result BEFORE applying this Pull Request

Action log works, but you get a PHP notice "Undefined variable: article"

Expected result AFTER applying this Pull Request

Action log still works as before, but there is no PHP notice "Undefined variable: article".

Documentation Changes Required

None.

avatar richard67 richard67 - open - 18 May 2021
avatar richard67 richard67 - change - 18 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 May 2021
Category Front End Plugins
avatar chmst chmst - test_item - 18 May 2021 - Tested successfully
avatar chmst
chmst - comment - 18 May 2021

I have tested this item successfully on 03684cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33941.

avatar alikon alikon - test_item - 18 May 2021 - Tested successfully
avatar alikon
alikon - comment - 18 May 2021

I have tested this item successfully on 03684cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33941.

avatar alikon alikon - change - 18 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33941.

avatar HLeithner HLeithner - change - 18 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-18 13:48:51
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner
HLeithner - comment - 18 May 2021

thanks

Add a Comment

Login with GitHub to post a comment