[#33921] - [4.0] fix a no jQuery error, com_finder
- Fixed in Code Base
- 17 May 2021
- Medium
- Build: 4.0-dev
- # 33921
- Diff
- dgrammatiko:—finder-no-jq—4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #33814 .
Summary of Changes
- Moves the js where it belongs, ie in it's own script file
- Fixes the invalid HTML, ie ids ARE unique
Testing Instructions
Follow the instructions on #33814
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33921.
Issue "Select switch" successfully test, but can't find the fixed HTML, so no submit a test result.
@sandramay0905 Fixed html can be checked in developer tools of the browser.
I looked in the source code for the 2 blue marked lines in the image in opening comment.
I looked in the source code for the 2 blue marked lines in the image in opening comment
And... ?
BTW the screenshot is from the before, as I wrote ids SHOULD be unique, so the fixed version doesn't have ids
The "tax-2" is now inside the class, there is no "id=":
@dgrammatiko I guess that's what you mean. If yes, i can give a successfully result.
I have tested this item
Thanks for help @dgrammatiko.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33921.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33921.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-17 16:41:20 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
I have tested this item✅ successfully on cd0e49f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33921.