Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33919] - [4.0] Hide the empty div when no results match the Add Module search

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
16 May 2021

Pull Request for Issue #33912

Summary of Changes

  • Added id to the h2 and div tags whose display is to be toggled
  • Added JavaScript code to toggle class d-none based on the hasResults and partialSearch boolean

Testing Instructions

Apply patch and npm run build:js to compile the JavaScript
For the following views, ensure that the div and h2 are not displayed when you enter a query that does not match any results:

  1. Backend -> Content -> Site Modules -> Add
  2. Backend -> Content -> Admin Modules -> Add
  3. Backend's Home Dashboard -> Add Module to the Dashboard -> Modal

Also, ensure that the box stays hidden when you navigate outside and then back again to the same view (for persistent query).

Actual result BEFORE applying this Pull Request

Add Module View

image

Modal

image

Expected result AFTER applying this Pull Request

Add Module View

hideDiv

Modal

hideDivModal

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 16 May 2021
avatar YatharthVyas YatharthVyas - change - 16 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2021
Category ⇒ Administration com_modules JavaScript Repository NPM Change
avatar RickR2H RickR2H - test_item - 16 May 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 16 May 2021

I have tested this item ✅ successfully on 2e324ea

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33919.

avatar sandramay0905 sandramay0905 - test_item - 17 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 17 May 2021

I have tested this item ✅ successfully on 2e324ea

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33919.

avatar richard67 richard67 - change - 17 May 2021
Status Pending ⇒ Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 17 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33919.

avatar chmst chmst - close - 17 May 2021
avatar chmst chmst - merge - 17 May 2021
avatar chmst chmst - change - 17 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-17 16:24:58
Closed_By ⇒ chmst
Labels Added: ?
avatar YatharthVyas
YatharthVyas - comment - 17 May 2021

Thanks all

Add a Comment

Login with GitHub to post a comment