[#33916] - [4.0] Fix template params for ErrorDocument, revert #33718
- Fixed in Code Base
- 17 May 2021
- Medium
- Build: 4.0-dev
- # 33916
- Diff
- Fedik:tmpl-error-params
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Summary of Changes
Assign the parameters to ErrorDocument to be available in error.php.
Reverts #33718.
Testing Instructions
For backend follow #33718
For frontend:
- set a theme color to "Alternative", in Cassiopeia config.
- open non existing page to get 404 error
- make sure the template use "Alternative color"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33916.
Should we change that in the error page on the Cassiopeia template
Yes, sure. I did not looked there, thanks for checking.
I will change.
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) Libraries | ⇒ | Administration Templates (admin) Libraries Front End Templates (site) |
@Fedik Could you add some testing instruction for the frontend part, too? Just something like "Check if the error page in frontend still works and looks as before", so other testers know they should check that.
@sandramay0905 Could you text that, too, frontend error page, and then set your test result again in the tracker? It doesn't need to repeat the other test for backend, for that there was no change since your test. Thanks in advance and thanks for all testing up to now.
updated :)
@richard67 Without pr i get the result see below so i'm not sure what to test:
@sandramay0905 Just check that it works with the PR as well as without the PR, i.e. colours are the same in both cases.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33916.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33916.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33916.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-17 14:32:06 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thanks
@Fedik @wilsonge Should we change that in the error page ot the Cassiopeia template, too?
It uses still the way with
$params = $app->getTemplate(true)->params;here:https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/error.php#L32-L33
And then
$paramsin the rest of the file.