? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
16 May 2021

Pull Request for Issue # .

Summary of Changes

Change th to td in grid.checkall and
Add scope in th

Testing Instructions

Code Review

avatar rjharishabh rjharishabh - open - 16 May 2021
avatar rjharishabh rjharishabh - change - 16 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2021
Category Administration com_installer
avatar rjharishabh rjharishabh - change - 16 May 2021
Title
[40] th scope
[4.0] th scope
avatar rjharishabh rjharishabh - edited - 16 May 2021
avatar brianteeman
brianteeman - comment - 16 May 2021

Sorry this is not correct. It is a cell not a header.

avatar rjharishabh
rjharishabh - comment - 16 May 2021

Sorry this is not correct. It is a cell not a header.

I don't understand what you want to say

I changed th to td because at all other places its td for example in articles

avatar brianteeman
brianteeman - comment - 16 May 2021

I am saying that this pr is not required. the cell you are changing is not a header. it doesnt contain information relating to the other cells in the column.

avatar rjharishabh
rjharishabh - comment - 16 May 2021

I am saying that this pr is not required. the cell you are changing is not a header. it doesnt contain information relating to the other cells in the column.

Or at first place where I change th to td

avatar brianteeman
brianteeman - comment - 16 May 2021

There is nothing to change. This PR should be closed.

avatar rjharishabh rjharishabh - change - 16 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-16 10:56:44
Closed_By rjharishabh
Labels Added: ?
avatar rjharishabh rjharishabh - close - 16 May 2021

Add a Comment

Login with GitHub to post a comment