[#33913] - [4.0] breadcrumbs unused function
- Closed
- 29 May 2021
- Medium
- Build: 4.0-dev
- # 33913
- Diff
- brianteeman:seperator
User tests: Successful: Unsuccessful:
This PR removes the function setSeparator that is not used in joomla 4
maintainers will need to decide if this is safe to delete or if it needs to be deprecated first.
Pull Request for Issue #33831
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
I have tested this item
I looked at the code and confirm that the function is not used anywhere in the core Joomla code. And that the breadcrumb separator is set by css.
What about those two png files that are not used? Should they be removed too? In a separate PR of course.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33913.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33913.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33913.
modules/mod_breadcrumbs/src/Helper/BreadcrumbsHelper.php
Is specific to the module so unlikely to be used by anything else
I've found nobody who could tell me why we should keep this function. No idea why the RLDQ label was set before.
Very unlikely but someone cloud have created an overwrite and used the function within the overwrite. Maybe better to mark it as depreciated and remove it with 5.0
ok - i will update or replace this later
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-29 15:23:29 |
| Closed_By | ⇒ | brianteeman |
Please remove use statements.