?
avatar YatharthVyas
YatharthVyas
16 May 2021

What needs to be fixed

Visit Backend -> Site Modules (or Admin Modules) -> Add New Module -> Enter a search query which doesn't match any result
Along with the 'No match found' alert, an empty card div is also displayed
Also, this can also be encountered by clicking on 'Add a module to the dashboard' modal button for the admin home dashboard.

image

Why this should be fixed

For consistency
If you observe the searchtools page for modules (or anything similar), it only shows a message when no modules match your query and no empty table

image

How would you fix it

The search works based on a JavaScript function in this file.
Maybe a boolean could be used to track whether any matches exists or not and that could be used as a condition to toggle the hidden class.

image

Side Effects expected

I think none

avatar YatharthVyas YatharthVyas - open - 16 May 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 May 2021
avatar YatharthVyas YatharthVyas - change - 16 May 2021
The description was changed
avatar YatharthVyas YatharthVyas - edited - 16 May 2021
avatar himanshu007-creator
himanshu007-creator - comment - 16 May 2021

@YatharthVyas i think this will be good!

avatar chmst
chmst - comment - 16 May 2021

Good for me

avatar YatharthVyas YatharthVyas - change - 16 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-16 14:00:06
Closed_By YatharthVyas
avatar YatharthVyas YatharthVyas - close - 16 May 2021
avatar YatharthVyas
YatharthVyas - comment - 16 May 2021

Closing in favor of PR #33919

Add a Comment

Login with GitHub to post a comment