User tests: Successful: Unsuccessful:
Pull Request for #28181 (comment) .
Fix the removal of folder libraries/joomla/base on update.
With commit 3200667 , the 2 files have been added to the folders list and not the folder.
Code review:
On current 3.10-dev, verify that the two files are in the list of files to be deleted here:
https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_admin/script.php#L2055-L2056
On current 3.10-dev, verify that they appear again in the list of folders to be deleted here:
https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_admin/script.php#L2298-L2299
On current staging, verify that these 2 files are the only files in their parent folder, see here:
https://github.com/joomla/joomla-cms/tree/staging/libraries/joomla/base
So if the files are removed on update, the folder can be removed, too.
Verify here that the change of this PR fixes point 2, so the folder is in the list of folders and not the files.
Wrong files /libraries/joomla/base/adapter.php and /libraries/joomla/base/adapterinstance.php in the list of folders to be deleted in script.php.
Right folder /libraries/joomla/base in the list of folders to be deleted in script.php.
None.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin |
I have tested this item
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-18 16:10:14 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merging thanks
I have tested this item✅ successfully on eeeadfc
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33868.