? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
14 May 2021

Pull Request for #28181 (comment) .

Summary of Changes

Fix the removal of folder libraries/joomla/base on update.

With commit 3200667 , the 2 files have been added to the folders list and not the folder.

Testing Instructions

Code review:

  1. On current 3.10-dev, verify that the two files are in the list of files to be deleted here:
    https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_admin/script.php#L2055-L2056

  2. On current 3.10-dev, verify that they appear again in the list of folders to be deleted here:
    https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_admin/script.php#L2298-L2299

  3. On current staging, verify that these 2 files are the only files in their parent folder, see here:
    https://github.com/joomla/joomla-cms/tree/staging/libraries/joomla/base
    So if the files are removed on update, the folder can be removed, too.

  4. Verify here that the change of this PR fixes point 2, so the folder is in the list of folders and not the files.

Actual result BEFORE applying this Pull Request

Wrong files /libraries/joomla/base/adapter.php and /libraries/joomla/base/adapterinstance.php in the list of folders to be deleted in script.php.

Expected result AFTER applying this Pull Request

Right folder /libraries/joomla/base in the list of folders to be deleted in script.php.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 14 May 2021
avatar richard67 richard67 - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Administration com_admin
avatar richard67 richard67 - change - 14 May 2021
The description was changed
avatar richard67 richard67 - edited - 14 May 2021
avatar brianteeman brianteeman - test_item - 14 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 May 2021

I have tested this item successfully on eeeadfc

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33868.

avatar saumyasarkar11 saumyasarkar11 - test_item - 15 May 2021 - Tested successfully
avatar saumyasarkar11
saumyasarkar11 - comment - 15 May 2021

I have tested this item successfully on eeeadfc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33868.

avatar richard67 richard67 - change - 15 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 15 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33868.

avatar zero-24 zero-24 - change - 18 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-18 16:10:14
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 18 May 2021
avatar zero-24 zero-24 - merge - 18 May 2021
avatar zero-24
zero-24 - comment - 18 May 2021

Merging thanks ?

Add a Comment

Login with GitHub to post a comment