Feeling Lucky
?
?
[#33867] - [4.0] Remove unnecessary code
- Fixed in Code Base
- 14 May 2021
- Medium
- Build: 4.0-dev
- # 33867
- Diff
- rjharishabh:unnecessary
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
one nav, div hard-coded into the file and the second nav, div comes from toolbar->render
I have removed the hard-coded part.
Testing Instructions
- Edit an Article
- Go to Versions
- Inspect the version toolbar
Both in frontend as well as backend
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
// cc @brianteeman
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
Quy
- comment
- 14 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33867.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 14 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33867.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-14 16:52:35 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
chmst
- comment
- 14 May 2021
Thanks!
I have tested this item✅ successfully on 45b477a
This corrects my bad in #33632 - thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33867.