Feeling Lucky
?
[#3386] - [#33534] Micro-optimization of JDocumentRendererHead/render
- Closed
- 6 Apr 2014
- Medium
- Build: staging
- # 3386
- Diff
- betweenbrain:issue-33534
- Foreign ID 33534
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The current code forJDocumentRendererHead/render uses an output buffer to return the result of a single echo statement. While very cool, I don't belive there is any advantage to this other than demonstrating excellent usage of output buffering.
With this change, my tests shows that we can expect the head portion of the page to render up to 0.000009 seconds faster while consuming up to 28,184 bytes less memory ;-) It also reduces the method to a single return statement.
Tracker item http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=33534
| Title |
|
||||||
betweenbrain
- comment
- 31 Mar 2014
Thanks Don!
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-06 13:34:35 |
| Labels | |||
Bakual
-
The
fetchHeadmethod that it's buffering doesn't have output anything, meaning there's nothing to buffer, so it's actually useless.This PR is good to merge. Thanks Matt!