Feeling Lucky
?
[#3385] - Fix for unintended use of setState, changed to getState
- Closed
- 28 Mar 2014
- Medium
- Build: staging
- # 3385
- Diff
- sovainfo:patch-5
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Very unlikely this is intentionally.
sovainfo
- comment
- 28 Mar 2014
No, don't know how to test.
Pretty sure it is wrong:
- set should have a value, not providing it should have been documented.
- all surrounding statements use the get
No-brainer to me!
Bakual
- comment
- 28 Mar 2014
It's indeed a typo. Unfortunately you can't test it as nothing is really broken.
That is because the setState method is returning the old value and thus the correct value is passed to the model state. 
Going to merge this.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-28 22:41:06 |
| Title |
|
||||||
puneet0191
-
It may very well be, but I'm not 100% certain. We'll need a tracker item and testing for sure, just to be on the safe side.
Have you tested an confirmed this code to be incorrect?