[#33839] - [4.0] Change tooltip style in articles
- Fixed in Code Base
- 14 May 2021
- Medium
- Build: 4.0-dev
- # 33839
- Diff
- rjharishabh:article-tooltip-joomla-style
User tests: Successful: Unsuccessful:
Summary of Changes
Change title to tooltip,
Add aria-labelledby in a
Testing Instructions
Go to the articles page
Please test with both RTL and LTR
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
@sandramay0905 I think it's by design
I have tested this item
The tooltip is distinct and reasonably well-placed in LTR and RTL. I think exact styling is a separate issue. For example, the tooltip shows/disapperas/shows on traversing a title broken over two lines.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.
I have tested this item
Changed the result by comments above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.
As this pr mentions Joomla style tooltip may I ask where this is documented? There are several ways to implement tooltips and I missed this one.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.
As this pr mentions Joomla style tooltip may I ask where this is documented? There are several ways to implement tooltips and I missed this one.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.
Joomla style tooltip means tooltip style used in Joomla 4 now
I will change the title
| Title |
|
||||||
You misunderstood! I am actually looking for the documentation that describes how to use Tooltips in Joomla. This has changed since Joomla 3 and I need to update some ancillary documentation. Your pr title was finr.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-14 09:51:59 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks
Please do same patch for other managers.
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise that would need to be done in a gazillion places.
The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
This PR should be reverted as its not correct.
I stopped using titles and tooltips some years ago after reading somewhere that they had accessibility issues (icons too). It would be nice to have some guidance (documentation) on where each could/should be/not be used in Joomla 4. I could write something if nothing exists but don't what the acceptable practice should be.
There is nothing wrong with titles. Used correctly they are perfectly accessible
The point is not so much accesibility here but to get a readable tip
why? it serves zero purpose other than to clutter the ui
The point is not so much accesibility here but to get a readable tip
If you are happy that this breaks accessibility then what has been the point in the last three years work
I have tested this item? unsuccessfully on af07820
Position of tooltip is different. With pr below end of link, without pr below mouse position:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.