No Code Attached Yet bug
avatar Kostelano
Kostelano
13 May 2021

Steps to reproduce the issue

Include the multilingual associations component / language filter plugin. Go to the menu, select, for example, the menu item HOME. On the associations tab:

  1. If the item is not assigned a language, the legend does not contain parameters. In this case, it is better to hide the legend or display the notification inside the legend.

  2. The type of notification does not match the Joomla styles 4. Or am I wrong? On the next tab (and in other places too), the notification style is different.

Screenshot_1

Notification in another tab:

Screenshot_2

avatar Kostelano Kostelano - open - 13 May 2021
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 May 2021
avatar YatharthVyas
YatharthVyas - comment - 13 May 2021

I think the reason they look different is that:

The second one is a fieldset description

<fieldset name="advanced" label="JGLOBAL_BLOG_LAYOUT_OPTIONS" description="JGLOBAL_SUBSLIDER_BLOG_LAYOUT_LABEL">

And the first one is an alert generated via JavaScript

if (associations) {
const html = document.createElement('joomla-alert');
html.innerHTML = Joomla.JText._('JGLOBAL_ASSOC_NOT_POSSIBLE');

I'm not sure if they need to have the same style because they are performing different tasks, ie. One is serving as a description and the other is an alert.

I do agree that the fieldset needs to be hidden in case of no associations which can be done by adding the following line to the if-block above.

document.getElementById('fieldset-associations').classList.add('hidden');

I'll be happy to submit a PR for this if someone can confirm whether only the fieldset needs to be hidden and/or the alert styles are also to be changed.

avatar Kostelano
Kostelano - comment - 13 May 2021

The tasks of notification and description are different, perhaps yes. But in Joomla 4, I have not seen the same style of notifications as in the associations tab. He clearly falls out of the general column.

If this notification is a warning, then we have the corresponding style - orange.

Certainly, I do not pretend to be true. Just thoughts.

avatar YatharthVyas
YatharthVyas - comment - 13 May 2021

Agreed, Your Point is Valid too

avatar Hackwar Hackwar - change - 22 Feb 2023
Labels Added: No Code Attached Yet bug
Removed: ?
avatar Hackwar Hackwar - labeled - 22 Feb 2023

Add a Comment

Login with GitHub to post a comment