Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33825] - [4.0] Optimize code

? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
12 May 2021

Summary of Changes

Swap check so isEnabled is only checked when the element is com_association instead of checking isEnabled with each menu item.

PS: See line 314 to see the same logic is applied.

Testing Instructions

Code review.

avatar Quy Quy - open - 12 May 2021
avatar Quy Quy - change - 12 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2021
Category ⇒ Modules Administration
avatar Quy Quy - change - 12 May 2021
The description was changed
avatar Quy Quy - edited - 12 May 2021
avatar joomdonation joomdonation - test_item - 12 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 12 May 2021

I have tested this item ✅ successfully on 387008f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33825.

avatar Quy Quy - change - 12 May 2021
The description was changed
avatar Quy Quy - edited - 12 May 2021
avatar richard67 richard67 - test_item - 12 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 12 May 2021

I have tested this item ✅ successfully on 387008f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33825.

avatar richard67 richard67 - change - 12 May 2021
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 12 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33825.

avatar drmenzelit drmenzelit - change - 12 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-12 18:35:54
Closed_By ⇒ drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 12 May 2021
avatar drmenzelit drmenzelit - merge - 12 May 2021
avatar drmenzelit
drmenzelit - comment - 12 May 2021

Thanks

Add a Comment

Login with GitHub to post a comment