User tests: Successful: Unsuccessful:
Pull Request for Issue #33823
Difference in the height of input and visibility button
Solved by adding a bootstrap bottom margin to 0.
Go to the main joomla web page and view it on mobile view.
<button type="button" class="btn btn-primary js-pstats-btn-allow-always m-1"><?php echo Text::_('PLG_SYSTEM_STATS_BTN_SEND_ALWAYS'); ?></button> <button type="button" class="btn btn-primary js-pstats-btn-allow-once m-1"><?php echo Text::_('PLG_SYSTEM_STATS_BTN_SEND_NOW'); ?></button> <button type="button" class="btn btn-primary js-pstats-btn-allow-never m-1" style="margin:0px"><?php echo Text::_('PLG_SYSTEM_STATS_BTN_NEVER_SEND'); ?></button>
No changes in the documentation.
| Status | New | ⇒ | Pending | 
| Category | ⇒ | Modules Front End | 
The problem is caused by
@media (max-width: 767.98px)
.btn {
    margin-bottom: .25rem;
}
Sorry, it's by mistake approved and I didn't revert it.
So, please don't consider these changes approved
I followed the GSOC guidelines to change the branch to 4.0-dev, so which branch should I choose?
I followed the GSOC guidelines to change the branch to 4.0-dev, so which branch should I choose?
@deveshprasad The branch is ok. It would have been better if you had created a new, extra branch for this PR based on the 4.0-dev branch, but as long as you don't make other PR's for other issues, it works like now, using your 4.0-dev branch.
Later when this PR is ok and tested and merged, the best is you delete your 4.0-dev branch and create it again based on the 4.0-dev branch of the CMS. Otherwise, if you don't do that and later create another PR based on your 4.0-dev branch which still contains your changes from this PR here, the other, future PR will be wrong.
But for now that should not be a problem.
Here you should change margin-bottom to 0
Here you should change margin-bottom to 0
The PR that introduced that code was #32697
I have tested this item 
Breaks all buttons see comments
Then it can be corrected by add mb-0 to it's markup.
That's in password. php file.
That would set a margin bottom at all screen sizes. Is that what you want to do?
So if the bootstrap margin is not the correct way and we should remove the entire class, and should directly set it to 0.
I tried applying bootstrap margin individually ( .btn) so that it won't affect the other buttons. But this is still not the correct way,
so can we add a new class on this button and which has its margin in the CSS files equal to 0?
I have a similar issue which I solved with help of bootstrap, but if m-1 is not the correct way as it works on all responsive screens
then can I add a new class because removing the current one will remove all those styling related with that class.
Similar issue:
| Status | Pending | ⇒ | Closed | 
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-15 10:55:42 | 
| Closed_By | ⇒ | deveshprasad | |
| Labels | 
                                        Added: 
?
 | 
    ||
I have tested this item?  unsuccessfully on 48a2894
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33824.