Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33822] - fix: Convert session ids returned from PostgreSQL

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar nibra
nibra
12 May 2021

Pull Request for Issue #33740 . alternative to #33787, #33817, #33819

When reading the session id from the session table on a PostgreSQL database, the result is an array of streams and not of strings.

Summary of Changes

If the session ids returned from the database are streams, they are converted into strings.
Additionally, duplicated code was reduced.

Testing Instructions

see #33740

Actual result BEFORE applying this Pull Request

see #33740

Expected result AFTER applying this Pull Request

Successfull logout. Session destroyed correctly.

Documentation Changes Required

None.

avatar nibra nibra - open - 12 May 2021
avatar nibra nibra - change - 12 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2021
Category ⇒ Front End Plugins
avatar nibra nibra - change - 12 May 2021
Labels Added: ?
avatar richard67
richard67 - comment - 12 May 2021

@nibra Fix PHP code style errors please: https://ci.joomla.org/joomla/joomla-cms/43569/1/6

avatar richard67
richard67 - comment - 12 May 2021

Adding release blocker label as inherited from the issue.

avatar nibra nibra - change - 12 May 2021
Labels Added: ?
avatar joomdonation joomdonation - test_item - 12 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 12 May 2021

I have tested this item ✅ successfully on 9313624

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822.

avatar nibra nibra - change - 12 May 2021
Labels Added: ?
Removed: ?
avatar joomdonation joomdonation - test_item - 12 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 12 May 2021

I have tested this item ✅ successfully on 7be5b7c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822.

avatar richard67 richard67 - test_item - 12 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 12 May 2021

I have tested this item ✅ successfully on 7be5b7c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822.

avatar richard67 richard67 - change - 12 May 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 12 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33822.

avatar chmst chmst - change - 13 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-13 21:31:39
Closed_By ⇒ chmst
Labels Added: ? ?
Removed: ?
avatar chmst chmst - close - 13 May 2021
avatar chmst chmst - merge - 13 May 2021
avatar chmst
chmst - comment - 13 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment