[#33821] - Fix of vertical line not having height
- Fixed in Code Base
- 14 May 2021
- Medium
- Build: 4.0-dev
- # 33821
- Diff
- eopws:autum-joomla-tab-layout-minor-change
User tests: Successful: Unsuccessful:
Pull Request for Issue #33809.
Summary of Changes
Vertical line that separates sidebar from content is extended to bottom (see screenshots and issue)
Testing Instructions
Go to Global Configuration > any component
Actual result BEFORE applying this Pull Request
The vertical line lack of height
Expected result AFTER applying this Pull Request
Everything is fine with height
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
Wasnt this by design?
I don't think so, because the line was created to separate sidebar from content and logically should be extended to the bottom
perhaps, perhaps not
I have tested this item
It works. So OK if accepted by designers.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-14 09:50:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
So much for waiting for feedback to see if it was by design. Just because something gets two successful tests does not mean it should be merged.
From a design perspective I would say this was indeed an issue to be fixed
Thank you for confirming
Wasnt this by design?