Alternative PR: #33819 .

Added release blocker label as inherited from the issue.

@alikon Should we close this in favor of #33819 ?

@alikon If we want to do it your way with this PR, you have to do the same here, too:

I don't mind mine,yours, etc , I know mine is a band-aid, should be
resolved on database side not on session

Il mer 12 mag 2021, 12:45 Richard Fath @.***> ha
scritto:

@alikon https://github.com/alikon If we want to do it your way with
this PR, you have to do the same here, too:

joomla-cms/plugins/user/joomla/joomla.php

Line 134 in b2849e9

if (!$sessionManager->destroySessions($sessionIds))

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33817 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABMLMMNTMWRPNJV5J3KVT3TNJL53ANCNFSM44X6KUGQ
.

@alikon Both are not nice and I understand what you mean. But as I said, please add the same change at the other place I've mentioned because we have the same issue there, reading the session id with loadColumn and so on.

I have PRed your branch @alikon for easy merging here alikon#71

@alikon If you merge @PhilETaylor 's PR alikon#71 , I'll close my PR in favour of this one.

I still prefer doing it in a central place but guess we will have to respect API design.

i don't know after this commit f8445ef
what is the current situation

I've closed my PR now in favour of this one.

I have tested this item ✅ successfully on a6536fd

@alikon Meanwhile I favour @nibra 's new PR #33822 . Please check if you come to the same conclusion.

closed in favour of #33822