[#33815] - [4.0] Show Multilingual Associations menu for multilingual sites only
- Fixed in Code Base
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33815
- Diff
- joomdonation:show_assocications_component_for_multilingual_sites_only
User tests: Successful: Unsuccessful:
Pull Request for Issue #33784.
Summary of Changes
The Multilingual Associations can only be used for multilingual website with Associations enabled in System - Language Filter plugin. This PRs modify code to only show Multilingual Associations menu item from Components menu backend if the conditions meet.
Testing Instructions
- Install Joomla 4.0-dev
- Access to Administrator area of your site, then access to Components menu item on the left sidebar
- Before patch, you see Multilingual Associations menu item
- Apply Patch:
- You see the menu item not being displayed
- Go to System -> Plugins, enable System - Language Filter and make sure Item Associations parameter set tot Yes. Then check it again, the menu item Multilingual Associations displayed.
Actual result BEFORE applying this Pull Request
Multilingual Associations menu item always displayed.
Expected result AFTER applying this Pull Request
Multilingual Associations menu item always displayed if conditions meet
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
@sandramay0905 What options you are talking about? Could you show me a screenshot? Thanks
The Options are shown even the multilingual associations are not visible by the pr:
Patch OK.
We could leave the Options imho as anyway I guess we should not introduce disabling a specific extension/component in com_config depending on the language filter setting.
The Options page would load ok and when closed, will anyway show the alert.
The only remaining hint to inform admin users that the site can be multilingual with associations, if desired.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33815.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33815.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 09:58:37 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
Thanks!
Maybe now we will be allowed to only show the multilingual sample data in the same situation?
@brianteeman I haven't tried that multilingual sample data, so I don't know. If the sample data install additional languages, enable the Language Filter plugin to make the site ready multilingual, then It should stay there. If not (just setup data like articles... only), then I think we can do the same check with how we are doing in this PR.
@joomdonation The multilingual sample data doesn't install languages. But it does all the rest, enable the Language Filter plugin, create menus and home menu items ...
Concerning the multilingual sample data: old discussion...
We have 2 informations:
- The description
- A warning when installing if only one language is present
imho, this is enough information and a good hint that the site can be multingual, info which is not provided anywhere else.
I have tested this item✅ successfully on 9b63c5f
Off topic this pull request, but shouldn't in the options the multilingual associations also be hidden? If yes, i can make a issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33815.