[#33793] - [4] Implement extra buttons to offline page
- Fixed in Code Base
- 24 May 2021
- Medium
- Build: 4.0-dev
- # 33793
- Diff
- PhilETaylor:addextrabuttonstooffline
User tests: Successful: Unsuccessful:
Pull Request for Issue #33779
Summary of Changes
Joomla 4 has the concept of Extra Buttons for the login page.
Joomla 4 also forgot to add this concept to the offline.php page for the default template.
Testing Instructions
- Activate Webauthn (you need to be on https://)
- Set the website into offline mode
- Try to login with Webauthn on FRONTEND
Actual result BEFORE applying this Pull Request
No extra buttons
Expected result AFTER applying this Pull Request
Extra buttons that work
Errors in the process also render correctly
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
|
||
| Category | Front End Templates (site) | ⇒ | Front End Templates (site) NPM Change |
I dont believe there is anymore to be done to satisfy the issue, which can now be closed.
This PR implements ALL the extra buttons, not just webauthn.
Offline.PHP is really a pain... Applied the patch and didn't saw any button until I found out that the page used a custom template ;)
Copy pasted the or into the other offline.php and it worked (style missing but that's a different story)
Commandment 11:
Thou shalt not use custom templates.
So that is a successful Test then yes? haha 
We are only responsible for the core templates, obviously, if you have custom templates then you will need this additional code to support the extra buttons feature :-) doh
Commandment 11:
Thou shalt not use a custom template that is not supporting child templates in Joomla 4
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33793.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33793.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33793.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-24 12:37:39 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
Can issue #33779 be closed with this PR here? Or should it stay open because there is more to do?