? ? Pending

User tests: Successful: Unsuccessful:

avatar eopws
eopws
11 May 2021

Pull Request for Issue #33697.

Summary of Changes

Little changes in layout of installer component

Testing Instructions

Go to administrator > com_installer and install any extension

Actual result BEFORE applying this Pull Request

The name of just installed extension is overlay the add extension form, which looks bad
before

Expected result AFTER applying this Pull Request

The name of just installed extension is positioned like in Joomla! 3
after

avatar eopws eopws - open - 11 May 2021
avatar eopws eopws - change - 11 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2021
Category Administration com_installer Repository NPM Change
avatar sandramay0905 sandramay0905 - test_item - 12 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 12 May 2021

I have tested this item successfully on 06f9e0b

With PR Without PR
Screen Shot 2021-05-12 at 10 30 55 Screen Shot 2021-05-12 at 12 50 02

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.
avatar ceford ceford - test_item - 12 May 2021 - Tested successfully
avatar ceford
ceford - comment - 12 May 2021

I have tested this item successfully on 06f9e0b

Better!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar richard67 richard67 - change - 12 May 2021
Status Pending Ready to Commit
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 12 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar eopws
eopws - comment - 12 May 2021

@sandramay0905 @ceford @richard67 Thanks for having time on this PR

avatar richard67 richard67 - change - 12 May 2021
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 12 May 2021

Back to pending, see review comments.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar eopws eopws - change - 13 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2021
Category Administration com_installer Repository NPM Change Administration com_installer
avatar eopws eopws - change - 13 May 2021
Labels Removed: NPM Resource Changed
avatar eopws
eopws - comment - 13 May 2021

Instead of adding a new class, how about using mb-3 or my-3?

Fixed.
@Quy, thanks for remark :)

avatar sandramay0905 sandramay0905 - test_item - 14 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 14 May 2021

I have tested this item successfully on 9b8efd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar Quy Quy - test_item - 14 May 2021 - Tested successfully
avatar Quy
Quy - comment - 14 May 2021

I have tested this item successfully on 9b8efd5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar Quy Quy - change - 14 May 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 14 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar Fedik
Fedik - comment - 15 May 2021

@eopws would be nicer if you wrap the message in to white box with padding, and add a margin bottom.

avatar Quy Quy - change - 15 May 2021
Status Ready to Commit Pending
avatar eopws
eopws - comment - 15 May 2021

@eopws would be nicer if you wrap the message in to white box with padding, and add a margin bottom.

Maybe alert alert-info class would be better?

avatar eopws eopws - change - 15 May 2021
Labels Added: ?
Removed: ?
avatar Quy Quy - test_item - 15 May 2021 - Tested successfully
avatar Quy
Quy - comment - 15 May 2021

I have tested this item successfully on 1be09d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar sandramay0905 sandramay0905 - test_item - 16 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 16 May 2021

I have tested this item successfully on 1be09d1

How it looks now:
image


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.
avatar Quy Quy - change - 16 May 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33781.

avatar richard67 richard67 - change - 17 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-17 18:58:43
Closed_By richard67
Labels Added: ?
Removed: ?
avatar richard67 richard67 - close - 17 May 2021
avatar richard67 richard67 - merge - 17 May 2021
avatar richard67
richard67 - comment - 17 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment