[#33780] - Update styling of the User Profile page and the Single Contact page
- Fixed in Code Base
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33780
- Diff
- RickR2H:4.0-dev-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #32561
Removed my previous PR #33603 and added the code from this PR and the missing styling for the contact page.
Summary of Changes
There where some styling issues in both the user profile page and the single contact regarding the dl-horizontal class and the edit user profile button. This PR fixes the styling issues.
Testing Instructions
Best way to test:
- Enable the User - Profile plugin
- Create a custom field in the Users Component
- Fill all the fields in the extra tab "User Profile" now visible in the Users component under the account settings.Also fill the new custom field value
- Enable as much options for the user account
- Create a custom field for the Contacts component
- Create a new contact in the Contacts component and Fill all the fields inducing the custom field
- Enable as much options newly created contact
- Link the Contact to the user profile under "Linked User"
- Create a menu item of type "User Profile"
- Create a menu item of type "Single Contact" and link this menu item to the created contact.
- Login to the frontend of the site and visit both menu items.
- Activate this PR and recreate the styling if necessary by running in the root of the site: npm run build:css
- Visit the pages again and look at the results.
Actual result BEFORE applying this Pull Request
See the left site of the screenshots
Expected result AFTER applying this Pull Request
See the right site of the screenshots
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_users Templates (site) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@drmenzelit Please check and test my new PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33780.
Good work! Thank you - looks much better now.
During test I have found that the params from #__contact_details are not used in the contact layout.
This is not related to your PR, so I will give it a good test.
But as you are active here at the moment, maybe you would like to fix this?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33780.
Looks great - thanks
This one https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_contact/tmpl/contact/default.php#L21
controls the behaviour, for example if a form is displayed or not.
But it does not contain the params from #__contact_details.
You can try this with setting for example the param "show_email_form" to "hide". This is set correct on #__contact_details, but it is not in $tparams.
This one https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_contact/tmpl/contact/default.php#L21
controls the behaviour, for example if a form is displayed or not.
But it does not contain the params from #__contact_details.
You can try this with setting for example the param "show_email_form" to "hide". This is set correct on #__contact_details, but it is not in $tparams.
Settings done in the Contact:Edit view are updated in the params field in #__contact_details. Normally the menu item can override the settings but this doesn't work. Maybe this is by design, but I have to check.
This one https://github.com/joomla/joomla-cms/blob/4.0-dev/components/com_contact/tmpl/contact/default.php#L21
controls the behaviour, for example if a form is displayed or not.
But it does not contain the params from #__contact_details.
You can try this with setting for example the param "show_email_form" to "hide". This is set correct on #__contact_details, but it is not in $tparams.
Best is to do a bug report with a good example how to reproduce the issue so someone can look into it.
Cheers!
Looks great - thanks
@brianteeman Was that a successful test? If so, could you mark the test result? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33780.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33780.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 09:36:03 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
|
||
Thank you :-)
@RickR2H Please fix the errors reported by the SCSS style linter here: https://ci.joomla.org/joomla/joomla-cms/43504/1/20 . Thanks in advance.