? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
11 May 2021

Pull Request for Issue # .

Summary of Changes

Add div role="tooltip"

Testing Instructions

Dashboard > Users > Messaging > Private Messages
If your site doesn't have any redirects, please create some redirects using New
tooltip com message
Hover on icons present in Read column
Apply PR
Again hover and see the difference

Actual result BEFORE applying this Pull Request

Non-Joomla style tooltip

Expected result AFTER applying this Pull Request

Joomla style tooltip

Documentation Changes Required

No

avatar rjharishabh rjharishabh - open - 11 May 2021
avatar rjharishabh rjharishabh - change - 11 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2021
Category Administration com_messages
avatar rjharishabh rjharishabh - change - 11 May 2021
Labels Added: ?
avatar rjharishabh rjharishabh - change - 11 May 2021
Title
[4.0] Add Joomla style tooltip in com-messages
[4.0] Add Joomla style tooltip in com_messages
avatar rjharishabh rjharishabh - edited - 11 May 2021
avatar Quy Quy - test_item - 11 May 2021 - Tested successfully
avatar Quy
Quy - comment - 11 May 2021

I have tested this item successfully on 7018148


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

avatar sandramay0905 sandramay0905 - test_item - 12 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 12 May 2021

I have tested this item successfully on 7018148


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

avatar richard67 richard67 - change - 12 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 12 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

avatar infograf768 infograf768 - close - 13 May 2021
avatar infograf768 infograf768 - merge - 13 May 2021
avatar infograf768 infograf768 - change - 13 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-13 06:45:32
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 13 May 2021

tks

avatar rjharishabh
rjharishabh - comment - 13 May 2021

Thanks for merging

avatar infograf768
infograf768 - comment - 13 May 2021

@rjharishabh

If you have time, you maybe could also change title to tooltip for the Managers where we have

Screen Shot 2021-05-13 at 08 47 21

Using (here for articles) something like

										<?php endif; ?>
										<?php if ($canEdit || $canEditOwn) : ?>
											<a href="<?php echo Route::_('index.php?option=com_content&task=article.edit&id=' . $item->id); ?>" aria-labelledby="edit-<?php echo (int) $item->id; ?>">
												<?php echo $this->escape($item->title); ?></a>
											<div role="tooltip" id="edit-<?php echo (int) $item->id; ?>"><?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?></div>
										<?php else : ?>

 to get
 
Screen Shot 2021-05-13 at 08 56 51

avatar rjharishabh
rjharishabh - comment - 13 May 2021

@infograf768 I will look into it soon

avatar rjharishabh
rjharishabh - comment - 14 May 2021

Add a Comment

Login with GitHub to post a comment