So the question here is what is correct. Red on hover or black on hover.

If we review the code base there is a fairly even split.

Looking at most of them the logic appears to have been
black for close
red for delete (or anything destructive)

IMO red for delete, say black for close
But when we add module in dashboard, red for close

Why not always black for close?

What is the logic behind that choice.

Agreed, Everywhere we should use black for close and red for delete
I choose red here because when I see the modal for Add module, red for close was there

So perhaps the problem is not here but with the add module ;)

So will I change here and all other places

I have tested this item ? unsuccessfully on adce5f4

• Applied PR
• Refreshed the page
• Clicked on Redirect System-Plugin
• Hovered on the Close-button
• Button did'nt change colour to black, it stay white.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33775.}

@sandramay0905

@rjharishabh Yes, that's what i have done but not successfully after install the pr per patchtester.

@rjharishabh Yes, that's what i have done but not successfully after install the pr per patchtester.

Don't know, then what's the problem

Sorry, i can only comment what i see on my side. Hopefully other can test successfully :-)

Sorry, i can only comment what i see on my side. Hopefully other can test successfully :-)

Yes, till then wait if someone tests it,
and based on their response I will update it
Thanks

If you look at the HtmlView.php file you will see that when there are no items the emptystate layout is used. You need need to change the btn class there too. Then come back and ask for a re-test. Test it yourself first!

Please test @ceford and @sandramay0905 once more
Thanks

I have tested this item ? unsuccessfully on adce5f4

• Applied PR
• Refreshed the page
• Clicked on Redirect System-Plugin
• Hovered on the Close-button
• Button did'nt change colour to black, it stay white.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33775.

Have you run "npm ci"?

I have tested this item ✅ successfully on 50871ab

You cracked it!

I have not tested this item.

Although it seems to work, onclick is taboo and you don't need it. The data-bs-dismiss will close the modal.

Although it seems to work, onclick is taboo and you don't need it. The data-bs-dismiss will close the modal.

This is the correct usage. As you can see it was also not added or edited by this PR so if you believe it should be changed then please create an issue for that. It is beyond the scope of this PR

@eopws

Have you run "npm ci"?

I have not run this because it isn't mentioned in the test instructions. Otherwise i would use prebuild packages.

There is no close button in the Modal Title bar: 'closeButton' => false,

I think that should be set to true in both templates.

npm ci is not required - this pr only changes php files

There is no close button in the Modal Title bar: 'closeButton' => false,
I think that should be set to true in both templates.

As you can see it was not added or edited by this PR so if you believe it should be changed then please create an issue for that. It is beyond the scope of this PR

I have tested this item ✅ successfully on 50871ab

I have tested this item ✅ successfully on 50871ab

RTC

Thank you!

Thanks for testing and merging