User tests: Successful: Unsuccessful:
Replaced the "original" PHPMailer library with the version from https://github.com/joomla-backports/PHPMailer
Set up site with working with working mail system (SMTP, mail(), sendmail).
Send test mail using the according button in the global configuration, verify mail arrived
apply patch
repeat step 2
Mail is sent.
Mail is sent.
None
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Composer Change Libraries |
The change with array_values which I've mentioned with the 2nd point in my above comment has been added by @HLeithner with PR #31440 . The PR doesn't tell anything about it in the description or any comments. Shall we keep that change?
The composer step is constantly failing in Drone at cloning the lessphp backport, see https://ci.joomla.org/joomla/joomla-cms/43478/1/2 .
I think the concept using
{
"type": "github",
"url": "https://github.com/joomla-backports/PHPMailer.git"
}
doesn't scale, we hit the free download limit even if I added my personal token...
Labels |
Added:
?
?
|
Category | External Library Composer Change Libraries | ⇒ | Repository External Library Composer Change Libraries |
The composer lock shows an update of the filter package from 2.0.0-beta3 to 2.0.0-beta4 ("source": "https://github.com/joomla-framework/filter/tree/2.0.0-beta4"), but that's not mentioned in the description of this PR. Is this intended?
@richard67 If I see that correctly it's just the "support" section, there is no actual update of the package being applied
I remember that in somce cases we had to add some array_values here or there before doing array_merge, but at this place this PR seems to revert that:
I re-added the array_values
Does it really need to add also stuff like the pull request template and the readme and so on? If so: Should the build script be extended so they not included in the packages?
Removed from PR
doesn't scale, we hit the free download limit even if I added my personal token...
@HLeithner I think I have a workaround - no-api flag seems to fix the issue
@SniperSister Is it desired that the stuff for tests is added to the libraries/vendor/composer/autoload_classmap.php
and the libraries/vendor/composer/autoload_static.php
file? Or should the composer maybe have been run with the --no-dev
option to exclude that?
@richard67 good catch, fixed!
I have tested this item
Tested with PHP 7.4 and with PHP 8.0, in both cases only with SMTP.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-18 11:53:12 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
Thanks
@SniperSister I have three questions:
"source": "https://github.com/joomla-framework/filter/tree/2.0.0-beta4"
), but that's not mentioned in the description of this PR. Is this intended?https://github.com/joomla/joomla-cms/pull/33772/files#diff-e415170f630137edaae6308a219e26f6a96f6bcc1641212dc4e7d931e4ac0f7dL63-R63
Can it be that we had a correction here which gets lost now with this PR because we hadn't ported that correction to the backport package?