User tests: Successful: Unsuccessful:
Pull Request for Issue #33490
I debugged the array of id(s) which were queried for deletion and their query result:
Array of ids to be deleted: [5,4,10,14,13,12,11,15,7,6,9,8,3,2]
Status:
5 - done
4 - done
10 - failed
id | Name | |
---|---|---|
5 | author/yatharthvyas | |
4 | author | |
10 | author/joomla | This conditional block for key not in table returned false and ended the execution here skipping all remaining queries in the array. |
The condition that checks if the key is in the table is now shifted outside the loop so when an element is deleted, that doesn't generate any error and return prematurely. Incase any key is not present, then it would be checked before deletion and the execution would stop then and there
#_finder_taxonomy
table to avoid the loss of any dataBefore the PR, only the first parent and its children would get deleted and then the function would return false skipping the remaining elements.
After the PR, you should see the Empty State, ie. All items deleted successfully.
Please refer to the video in #33490
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_finder |
Labels |
Added:
?
|
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-11 12:54:36 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Thank you!
Thanks everyone
I have tested this item✅ successfully on 9b14e15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33771.