Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33735] - [4.0] Backend - Fix Privacy Requests Alert

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
10 May 2021

Pull Request for Issue #33696

Summary of Changes

  • Add two missing language strings to the js file and modified the alert code by removing the old parts. (This fixed the undefined)
  • Add btn-small class so the Button doesn't look oversized as compared to the text
  • The 4.0 language string for the message uses %s to map the Count of Messages and hence I added the entire text inside the countSpan to ensure that it stays together and so that the use of innerHTML is avoided. In the previous language string, there was no %s so that justifies why the initial code could have the count and string in separate HTML tags.

Testing Instructions

  1. Please follow the instructions given in #33696
  2. Apply Patch and npm run build:js

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 10 May 2021
avatar YatharthVyas YatharthVyas - change - 10 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2021
Category ⇒ JavaScript Repository NPM Change Front End Plugins
avatar YatharthVyas YatharthVyas - change - 10 May 2021
The description was changed
avatar YatharthVyas YatharthVyas - edited - 10 May 2021
avatar YatharthVyas YatharthVyas - change - 10 May 2021
Labels Added: NPM Resource Changed ?
avatar sandramay0905 sandramay0905 - test_item - 11 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 11 May 2021

I have tested this item ✅ successfully on 56676fb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33735.

avatar ceford ceford - test_item - 11 May 2021 - Tested successfully
avatar ceford
ceford - comment - 11 May 2021

I have tested this item ✅ successfully on 56676fb

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33735.

avatar ceford
ceford - comment - 11 May 2021

And I see you have the Home Dashboard problem for which I described a fix in the Forum: https://forum.joomla.org/viewtopic.php?f=803&t=986269&sid=c9245193e86a36cac77c0c382ea9ad1c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33735.

avatar richard67 richard67 - change - 11 May 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 11 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33735.

avatar Quy Quy - change - 12 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-12 21:49:21
Closed_By ⇒ Quy
Labels Added: ?
avatar Quy Quy - close - 12 May 2021
avatar Quy Quy - merge - 12 May 2021
avatar Quy
Quy - comment - 12 May 2021

Thanks

avatar YatharthVyas
YatharthVyas - comment - 13 May 2021

Thank you

Add a Comment

Login with GitHub to post a comment