?
avatar ceford
ceford
10 May 2021

Steps to reproduce the issue

Go to Administrator / Help / Start Here - Joomla! Help
Scroll down to near the bottom of the long list and click an item there

Expected result

Something should happen

Actual result

Nothing appears to happen because the Iframe with the new help page has been loaded out of sight.

System information (as much as possible)

Additional comments

I previously had a fix committed for this issue using a scrolling div for the index. The css for this has been removed in the recent round of template clean up. I now have a different solution using scroll to top on selecting any help item. For my testing I have put this in the com_admin/tmpl/help/default.php like so:

$wa = $this->document->getWebAssetManager();
$content = "
document.addEventListener('DOMContentLoaded', function(event) {
	let helpIndex = document.getElementById('help-index');
	let links = helpIndex.querySelectorAll('a');
	links && links.forEach(element => {
		element.addEventListener('click', event => {
			window.scroll(0,0);
		});
	})
});
";
$wa->addInlineScript($content);

Is that best, or should it be in one of the Javascript files?

avatar ceford ceford - open - 10 May 2021
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 May 2021
avatar sandewt
sandewt - comment - 10 May 2021
avatar dgrammatiko
dgrammatiko - comment - 10 May 2021

Is that best, or should it be in one of the Javascript files?

Please use a file, don't use inline scripts

avatar alikon alikon - change - 10 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-10 16:45:09
Closed_By alikon
avatar alikon alikon - close - 10 May 2021
avatar alikon
alikon - comment - 10 May 2021

please test #33724
sorry #33742

avatar sandewt
sandewt - comment - 10 May 2021

please test #33724

Should be:

please test #33742

avatar alikon
alikon - comment - 10 May 2021

oops

Add a Comment

Login with GitHub to post a comment