[#33599] - [4][atum] 403 page has wrong font colour
- Closed
- 8 May 2021
- Medium
- Build: staging
- # 33599
Steps to reproduce the issue
Logout of Joomla 4 admin
Go to a URL that generates a 403 Forbidden message - here is a quick example:
http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw
Expected result
white text not black text in left sidebar
Actual result
System information (as much as possible)
safari on mac
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
In Cassiopeia's error page we also use params from its template style, so it should also be ok for Atum's error page. So it just needs someone having time and mood to fix it.
I can reproduce the issue. I see the same as the screenshot.
I understand the issue... but... those params are behind locked doors.
On the other hand... I do see some styling.... so I do have some kind of permissions to see the admin template.
When we try to login we don't have permissions either... so displaying this error page should be able to render with the same parameters as the login screen does.
trying to debug the issue now and creating a PR
login.php
in the <head>
<style nonce="ZjNkY2VhNGZkOTZmYmQ4NDc0OTAwZmNkMDI5OWIzYWQ5YmI3Mzk0MDdjMGI0MTcxOGFlYjg2ZGQ2MmE1ZjBlYmVhNzM0ZDlkNDUzZTdhNTIxNDNmMDUyMmRlNWU1ZGJjMTY3ZDc0M2JmNDdiMTUwMDFkNTVkZTRlNmJiYmU2MTQ=">:root {
--hue: 214;
--atum-bg-light: #f0f4fb;
--atum-text-dark: #495057;
--atum-text-light: #ffffff;
--atum-link-color: #2a69b8;
--atum-special-color: #001b4c;
}</style>
error_login.php
in the <head>
<style nonce="MDMxYjQxYjA0MWQ3ZWNlMmZkZmJmNjkzNDU3Y2VjMDE4NDhlNTAwMjUwNWI4MzUxN2YxMWU2Nzg2ZDI2NTRiNzcxYmVlZTFhYWI1NGM3MDI4MzBlMzdjNTA3Yzk3YjAyZTUxMDc2ZDJiOGMwN2RlNzBjMzFiNTkyM2ZlODlhYjM=">:root {
--hue: 214;
--atum-bg-light: --atum-bg-light;
--atum-text-dark: --atum-text-dark;
--atum-text-light: --atum-text-light;
--atum-link-color: --atum-link-color;
--atum-special-color: --atum-special-color;
}</style>
This backs the findings of @brianteeman saying that the error page does not get the template params.
color issue
At the beginning of login.php and index.php I see:
/** @var JDocumentHtml $this */
(should be rewritten to HTMLDocument and I will do that in a PR)
At the beginning of error.php, error_full.php and error_login.php I see:
/** @var JDocumentError $this */
(should be rewritten to ErrorDocument and I will do that in a PR)
Investigating HTMLDocument I see
joomla-cms/libraries/src/Document/HtmlDocument.php
Lines 60 to 66 in 6639c07
Investigating ErrorDocument I can't find $params
Because $params are not present in ErrorDocument one cannot call them on the error pages.
update
I'm confused..
Since ErrorDocument extends HTMLDocument it should be able to get the params. Or am I wrong?
ciar4n
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-08 18:01:28 |
| Closed_By | ⇒ | ciar4n |
The problem is that none of the error pages are getting the params from the template.